From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LolYc-0002AA-Vz
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 17:31:43 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LolYY-00025b-F4
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 17:31:42 -0400
Received: from [199.232.76.173] (port=60974 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LolYY-00025R-6x
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 17:31:38 -0400
Received: from mx20.gnu.org ([199.232.41.8]:38493)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1LolYX-0000TO-UP
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 17:31:38 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1LolYW-0008QC-FB
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 17:31:36 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 13/17] Strace is now working again with
	GUEST_BASE support.
Date: Tue, 31 Mar 2009 21:31:33 +0000
References: <cover.1238531008.git.riku.voipio@iki.fi>
	<3dc7b7b91d973c093c5899f299c055bb4d7b1c34.1238531009.git.riku.voipio@iki.fi>
In-Reply-To: <3dc7b7b91d973c093c5899f299c055bb4d7b1c34.1238531009.git.riku.voipio@iki.fi>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200903312231.33726.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: riku.voipio@iki.fi

On Tuesday 31 March 2009, riku.voipio@iki.fi wrote:
> From: Mika Westerberg <mika.westerberg@iki.fi>
>
> Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
> ---
>  linux-user/strace.c    |  170
> ++++++++++++++++++++++++++++++++++++++++++++++++ linux-user/strace.list | 
> 101 +++++++++++++++++-----------
>  2 files changed, 232 insertions(+), 39 deletions(-)

It would help if you included a description of what the patch actually does.

> + * This function locks strings from guest memory and prints
> + * strace output according to format specified in strace.list.

This seems a poor way of implementing this. Much better would be to parse the 
format string and make this happen automatically for %s arguments and/or add 
a new format specifier.

Paul