From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: riku.voipio@iki.fi
Subject: Re: [Qemu-devel] [PATCH 05/17] Fix and cleanup IPCOP_shm* ipc calls handling
Date: Tue, 31 Mar 2009 22:08:52 +0000 [thread overview]
Message-ID: <200903312308.53162.paul@codesourcery.com> (raw)
In-Reply-To: <0007b0851a779060f010f33e9f5c79d818ce9d21.1238531009.git.riku.voipio@iki.fi>
On Tuesday 31 March 2009, riku.voipio@iki.fi wrote:
> + *raddr = (unsigned long) shmat(shmid, g2h(shmaddr), shmflg);
This is wrong. You need to handle NULL properly.
Paul
next prev parent reply other threads:[~2009-03-31 22:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-31 20:40 [Qemu-devel] [PATCH 00/17] linux-user patches in maemo riku.voipio
2009-03-31 20:40 ` [Qemu-devel] [PATCH 01/17] Fix fstatat64()/newfstatat() syscall implementation riku.voipio
2009-03-31 20:40 ` [Qemu-devel] [PATCH 02/17] Rewrite mmap_find_vma() to work fine on 64-bit hosts with 32-bit targets riku.voipio
2009-03-31 20:40 ` [Qemu-devel] [PATCH 03/17] Fix and cleanup IPCOP_sem* ipc calls handling riku.voipio
2009-03-31 20:40 ` [Qemu-devel] [PATCH 04/17] Implement sem* syscalls riku.voipio
2009-03-31 20:40 ` [Qemu-devel] [PATCH 05/17] Fix and cleanup IPCOP_shm* ipc calls handling riku.voipio
2009-03-31 22:08 ` Paul Brook [this message]
2009-03-31 20:40 ` [Qemu-devel] [PATCH 06/17] Implement shm* syscalls riku.voipio
2009-03-31 20:40 ` [Qemu-devel] [PATCH 07/17] shmat(): use mmap_find_vma to find free memory area riku.voipio
2009-03-31 20:40 ` [Qemu-devel] [PATCH 08/17] Added posix message queue syscalls except mq_notify riku.voipio
2009-03-31 20:40 ` [Qemu-devel] [PATCH 09/17] Format mq_open strace arguments riku.voipio
2009-03-31 20:40 ` [Qemu-devel] [PATCH 10/17] More strace formatting for posix message queues syscalls riku.voipio
2009-03-31 20:40 ` [Qemu-devel] [PATCH 11/17] Add support for passing contents of argv0 riku.voipio
2009-03-31 20:40 ` [Qemu-devel] [PATCH 12/17] linux-user: unix sockets - fix running dbus riku.voipio
2009-03-31 23:36 ` [Qemu-devel] [PATCH 12/17] linux-user: unix sockets - fix runningdbus Krumme, Chris
2009-04-05 18:04 ` Riku Voipio
2009-03-31 20:40 ` [Qemu-devel] [PATCH 13/17] Strace is now working again with GUEST_BASE support riku.voipio
2009-03-31 21:31 ` Paul Brook
2009-04-01 6:49 ` Mika Westerberg
2009-03-31 20:40 ` [Qemu-devel] [PATCH 14/17] Revived GUEST_BASE support for usermode emulation targets riku.voipio
2009-03-31 21:51 ` Paul Brook
2009-03-31 20:40 ` [Qemu-devel] [PATCH 15/17] linux-user: removed unnecessary MAX_SOCK_ADDR checks for socket syscalls riku.voipio
2009-03-31 20:40 ` [Qemu-devel] [PATCH 16/17] Prefer glibc over direct syscalls riku.voipio
2009-03-31 20:40 ` [Qemu-devel] [PATCH 17/17] linux-user: Proper exit code for uncaught signals riku.voipio
2009-03-31 22:31 ` [Qemu-devel] [PATCH 00/17] linux-user patches in maemo Paul Brook
2009-04-01 9:31 ` Riku Voipio
2009-04-01 12:07 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903312308.53162.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).