From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lomi5-0001pO-K5
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 18:45:33 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lomi1-0001oB-6h
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 18:45:33 -0400
Received: from [199.232.76.173] (port=50795 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lomi1-0001o8-2I
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 18:45:29 -0400
Received: from mx20.gnu.org ([199.232.41.8]:39795)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1Lomi0-0001Dg-Mx
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 18:45:28 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1Lomhz-0002eZ-NS
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 18:45:28 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 02/10] Specialize tcg_gen_not_i64 for 32-bit
	targets
Date: Tue, 31 Mar 2009 22:45:23 +0000
References: <1238274167-7890-1-git-send-email-froydnj@codesourcery.com>
	<1238274167-7890-3-git-send-email-froydnj@codesourcery.com>
In-Reply-To: <1238274167-7890-3-git-send-email-froydnj@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200903312345.23710.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Nathan Froyd <froydnj@codesourcery.com>

>  #ifdef TCG_TARGET_HAS_not_i64
>      tcg_gen_op2_i64(INDEX_op_not_i64, ret, arg);
> +#elif defined(TCG_TARGET_HAS_not_i32)
> +    tcg_gen_not_i32(TCGV_LOW(ret), TCGV_LOW(arg));
> +    tcg_gen_not_i32(TCGV_HIGH(ret), TCGV_HIGH(arg));
>  #else
>      tcg_gen_xori_i64(ret, arg, -1);

This is only valid when TCG_TARGET_REG_BITS == 32

Annother possibility is to move the the op_not generation to gen_xori. You 
should get this for free then.

Paul