From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LppxM-0004jH-PB for qemu-devel@nongnu.org; Fri, 03 Apr 2009 16:25:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LppxI-0004h5-Ch for qemu-devel@nongnu.org; Fri, 03 Apr 2009 16:25:40 -0400 Received: from [199.232.76.173] (port=44600 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LppxH-0004gp-Sg for qemu-devel@nongnu.org; Fri, 03 Apr 2009 16:25:35 -0400 Received: from mx2.redhat.com ([66.187.237.31]:60936) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LppxH-00021C-Ev for qemu-devel@nongnu.org; Fri, 03 Apr 2009 16:25:35 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n33KPYcQ011588 for ; Fri, 3 Apr 2009 16:25:34 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n33KPZ7B014014 for ; Fri, 3 Apr 2009 16:25:36 -0400 Received: from localhost (vpn-6-65.fab.redhat.com [10.33.6.65]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n33KPXEE021655 for ; Fri, 3 Apr 2009 16:25:34 -0400 Date: Fri, 3 Apr 2009 21:25:32 +0100 From: "Richard W.M. Jones" Subject: Re: [Qemu-devel] [PATCH] Remove debug message printed when you use -initrd Message-ID: <20090403202532.GA28406@amd.home.annexia.org> References: <20090403201449.GA28322@amd.home.annexia.org> <49D66F23.9050601@codemonkey.ws> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="tKW2IUtsqtDRztdT" Content-Disposition: inline In-Reply-To: <49D66F23.9050601@codemonkey.ws> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org --tKW2IUtsqtDRztdT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 03, 2009 at 03:18:43PM -0500, Anthony Liguori wrote: > Richard W.M. Jones wrote: >> I wonder if we could remove this annoying debug message, which is >> printed unconditionally whenever someone uses the -initrd command line >> option. >> >> Rich. >> > > Needs a Signed-off-by. I always forget it! Is this OK? Signed-off-by: Richard W.M. Jones Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top --tKW2IUtsqtDRztdT Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="qemu-no-initrd-message.patch" Index: hw/pc.c =================================================================== --- hw/pc.c (revision 6970) +++ hw/pc.c (working copy) @@ -649,9 +649,6 @@ initrd_size = get_file_size(fi); initrd_addr = (initrd_max-initrd_size) & ~4095; - fprintf(stderr, "qemu: loading initrd (%#x bytes) at 0x" TARGET_FMT_plx - "\n", initrd_size, initrd_addr); - if (!fread_targphys_ok(initrd_addr, initrd_size, fi)) { fprintf(stderr, "qemu: read error on initial ram disk '%s'\n", initrd_filename); --tKW2IUtsqtDRztdT--