From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LqWiB-0002FD-Lv for qemu-devel@nongnu.org; Sun, 05 Apr 2009 14:04:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LqWiA-0002Do-0c for qemu-devel@nongnu.org; Sun, 05 Apr 2009 14:04:51 -0400 Received: from [199.232.76.173] (port=47486 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LqWi9-0002Db-Pv for qemu-devel@nongnu.org; Sun, 05 Apr 2009 14:04:49 -0400 Received: from naru.obs2.net ([84.20.150.76]:60122) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LqWi9-0006bD-8j for qemu-devel@nongnu.org; Sun, 05 Apr 2009 14:04:49 -0400 Received: from kos.to (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by narury.org (Postfix) with ESMTP id BDB1D3274001 for ; Sun, 5 Apr 2009 21:04:37 +0300 (EEST) Date: Sun, 5 Apr 2009 21:04:37 +0300 From: Riku Voipio Subject: Re: [Qemu-devel] [PATCH 12/17] linux-user: unix sockets - fix runningdbus Message-ID: <20090405180437.GA15319@kos.to> References: <581b68b457e8dc8c38b9ea5b3df236282284fed5.1238531009.git.riku.voipio@iki.fi> <58BD0469C48A7443A479A13D101685E30227F677@ala-mail09.corp.ad.wrs.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58BD0469C48A7443A479A13D101685E30227F677@ala-mail09.corp.ad.wrs.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Tue, Mar 31, 2009 at 04:36:58PM -0700, Krumme, Chris wrote: > > + if (sa_family == AF_UNIX) { > > + if (len < unix_maxlen) { > > + char *cp = (char*)target_saddr; > > + > > + if ( cp[len-1] && !cp[len] ) > This could be a little weird if len were 0. Oops, patch fixed.