From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LrEDW-0001ND-VQ for qemu-devel@nongnu.org; Tue, 07 Apr 2009 12:32:07 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LrEDS-0001Mv-Br for qemu-devel@nongnu.org; Tue, 07 Apr 2009 12:32:06 -0400 Received: from [199.232.76.173] (port=51646 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LrEDS-0001Ms-3Y for qemu-devel@nongnu.org; Tue, 07 Apr 2009 12:32:02 -0400 Received: from bsdimp.com ([199.45.160.85]:56294 helo=harmony.bsdimp.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LrEDR-00067o-Dj for qemu-devel@nongnu.org; Tue, 07 Apr 2009 12:32:01 -0400 Date: Tue, 07 Apr 2009 10:29:30 -0600 (MDT) Message-Id: <20090407.102930.163259968.imp@bsdimp.com> Subject: Re: [Qemu-devel] Changing the QEMU svn VERSION string From: "M. Warner Losh" In-Reply-To: <264E220E-78B4-4A46-93E3-B896192058EB@web.de> References: <49DABC83.7010608@codemonkey.ws> <264E220E-78B4-4A46-93E3-B896192058EB@web.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, andreas.faerber@web.de In message: <264E220E-78B4-4A46-93E3-B896192058EB@web.de> Andreas_F=E4rber writes: : Hi, : = : On the topic of QEMU help output, it still reads: : Copyright (c) 2003-2008 Fabrice Bellard : = : Since the code was last modified in 2009, I feel that should be = : reflected in some copyright statement. Likely. : Given that iirc Fabrice has not contributed code this year, I see two= = : options: : = : Copyright (c) 2003-2009 Fabrice Bellard and contributors : = : Or if we want to stick with one maintainer's name only: : = : Copyright (c) 2003-2008 Fabrice Bellard : Copyright (c) 2008-2009 Anthony Liguori What purpose is this copyright notice? Is it to notify users of the collection copyright (eg, the gluing together of everything)? In that case, the above is fine. If it is supposed to be for everybody's individual contributions, then none of the above are sufficient (or required). However, it likely would be good to include a contributors page. I haven't reviewed all the licenses in all the files in the system, but it never hurts to have a file that acknowledges all the copyrights in a central place. Unlike trademarks, you can't say "Copyright by a bunch of folks" That's not valid copyright notice, and that's what the "and contributors" does.... My recommendation would be to go with the second form. Warner : Am 07.04.2009 um 04:37 schrieb Anthony Liguori: : = : > Hi, : > : > I'd like to update the VERSION string in QEMU's svn tree. Right = : > now, it's 0.10.0 and since we have a 0.10.2 release, that's somewha= t = : > confusing. : > : > I don't want to make it 0.11.0 either because that's not going to b= e = : > reliable from a feature detection perspective. What I would like i= s = : > to make it 0.11.0-devel or something similar to that. : > : > Being the nice guy I am, I thought I would check that this didn't = : > make libvirt go bonkers :-) This is the relevant detection code in= = : > libvirt: : > : > : > if (sscanf(help, "QEMU PC emulator version %u.%u.%u (kvm-%u)", : > &major, &minor, µ, &kvm_version) !=3D 4) : > kvm_version =3D 0; : > : > if (!kvm_version && sscanf(help, "QEMU PC emulator version u.%u.%u"= , : > &major, &minor, µ) !=3D 3) : > goto cleanup2; : > : > If I change SVN to 0.11.0-devel, that's going to break the KVM = : > string although the QEMU string will continue to work. Avi could = : > potentially carry a patch to keep it 0.10.x and since kvm-%u will b= e = : > used to identify features, that should keep things working. : > : > : > Anyone have any objections/suggestions? : > : > Regards, : > : > Anthony Liguori : > : > : = : = : = : =