From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lrbcu-0005nh-PH
	for qemu-devel@nongnu.org; Wed, 08 Apr 2009 13:31:52 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lrbcp-0005ff-Pc
	for qemu-devel@nongnu.org; Wed, 08 Apr 2009 13:31:52 -0400
Received: from [199.232.76.173] (port=52653 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lrbcp-0005fR-HD
	for qemu-devel@nongnu.org; Wed, 08 Apr 2009 13:31:47 -0400
Received: from mx20.gnu.org ([199.232.41.8]:15501)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1Lrbcp-0000yH-88
	for qemu-devel@nongnu.org; Wed, 08 Apr 2009 13:31:47 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1Lrbcn-0006yh-Sd
	for qemu-devel@nongnu.org; Wed, 08 Apr 2009 13:31:46 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] Re: start qemu failed with --enable-kvm -vga std
Date: Wed, 8 Apr 2009 17:31:41 +0000
References: <fb7465350904072011r6e30db95y20c274c88cc9a29c@mail.gmail.com>
	<5d6222a80904080625k4aa8186fo451772b70509f595@mail.gmail.com>
	<49DCD212.5050200@siemens.com>
In-Reply-To: <49DCD212.5050200@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200904081831.43001.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Glauber Costa <glommer@redhat.com>

> > I believe this is in fact the root cause. KVM slot management code
> > probably require
> > memory to be page aligned. By trying to register a region that is not
> > page aligned,
> > the ioctl may fail. I, however, did not see this happening in qemu
> > upstream (only kvm-userspace),
> > and have absolutely no idea about why. But the patch makes perfect sense
> > to me.
>
> But this really sounds like a limitation that should better be fixed in
> the kvm layer, not the device/machine code.

I was meaning more why we're creating regions for individual roms. Just map 
the whole block at once.

FWIW kvm probably needs to be able to handle small regions anyway, some PCI 
devices require them.

Paul