From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LruAj-0001Ws-5j
	for qemu-devel@nongnu.org; Thu, 09 Apr 2009 09:20:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LruAe-0001Th-Jf
	for qemu-devel@nongnu.org; Thu, 09 Apr 2009 09:20:00 -0400
Received: from [199.232.76.173] (port=43894 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LruAe-0001Ta-B6
	for qemu-devel@nongnu.org; Thu, 09 Apr 2009 09:19:56 -0400
Received: from verein.lst.de ([213.95.11.210]:56920)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1LruAd-0005wR-TA
	for qemu-devel@nongnu.org; Thu, 09 Apr 2009 09:19:56 -0400
Received: from verein.lst.de (localhost [127.0.0.1])
	by verein.lst.de (8.12.3/8.12.3/Debian-7.1) with ESMTP id
	n39DJqIF017341
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO)
	for <qemu-devel@nongnu.org>; Thu, 9 Apr 2009 15:19:52 +0200
Received: (from hch@localhost)
	by verein.lst.de (8.12.3/8.12.3/Debian-6.6) id n39DJpAw017339
	for qemu-devel@nongnu.org; Thu, 9 Apr 2009 15:19:51 +0200
Date: Thu, 9 Apr 2009 15:19:51 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] buffer alignment for block backends
Message-ID: <20090409131951.GA17258@lst.de>
References: <49DCA80A.1020808@eu.citrix.com> <49DCF2C0.9070704@codemonkey.ws>
	<49DDC8E0.50900@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <49DDC8E0.50900@eu.citrix.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Thu, Apr 09, 2009 at 11:07:28AM +0100, Stefano Stabellini wrote:
> +    acb->bounce = qemu_blockalign(qiov->size);

Why don't you pass a BlockDriverState to it so that it automatically
does the best alignment for the underlying driver?