From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ls1Qg-0008SZ-Oh for qemu-devel@nongnu.org; Thu, 09 Apr 2009 17:04:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ls1Qc-0008Pz-32 for qemu-devel@nongnu.org; Thu, 09 Apr 2009 17:04:58 -0400 Received: from [199.232.76.173] (port=59962 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ls1Qb-0008Pl-HW for qemu-devel@nongnu.org; Thu, 09 Apr 2009 17:04:53 -0400 Received: from mx20.gnu.org ([199.232.41.8]:31625) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ls1Qb-0005dp-4s for qemu-devel@nongnu.org; Thu, 09 Apr 2009 17:04:53 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ls1QZ-0004A8-UC for qemu-devel@nongnu.org; Thu, 09 Apr 2009 17:04:52 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH 1/2] register a single area for vga bios and option roms Date: Thu, 9 Apr 2009 22:04:48 +0100 References: <1239308420-10521-1-git-send-email-glommer@redhat.com> <1239308420-10521-2-git-send-email-glommer@redhat.com> In-Reply-To: <1239308420-10521-2-git-send-email-glommer@redhat.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200904092204.49029.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: jan.kiszka@siemens.com, Glauber Costa , aliguori@us.ibm.com On Thursday 09 April 2009, Glauber Costa wrote: > Those guys are not different in nature. They're all roms, > not blessed with the graces of being written to. So there's > not need to issue multiple requests to memory registration areas: > just treat them as brothers, and put them all in the same > region. I fixed a bug (missing += when loading option roms), simplified the rounding a bit, added a check for overflow, fixed several formatting errors, and applied the patch. Paul