[Qemu-devel] QEMU TCG code does not build with OpenBSD PowerPC

[Qemu-devel] QEMU TCG code does not build with OpenBSD PowerPC

[Brad]

Trying to build on an OpenBSD PowerPC machine dies pretty quickly
in the TCG PowerPC code..

   CC    i386-softmmu/exec.o
 In file included from /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/tcg/tcg.h:24,
                  from /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/exec.c:39:
 /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/tcg/ppc/tcg-target.h:76:2: #error 
Unsupported system
 gmake[1]: *** [exec.o] Error 1

Any help with this?

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Re: [Qemu-devel] QEMU TCG code does not build with OpenBSD PowerPC

[Andreas Färber]

Am 10.04.2009 um 14:21 schrieb Brad:

> Trying to build on an OpenBSD PowerPC machine dies pretty quickly
> in the TCG PowerPC code..
>
>   CC    i386-softmmu/exec.o
> In file included from /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/tcg/ 
> tcg.h:24,
>                  from /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/exec.c: 
> 39:
> /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/tcg/ppc/tcg-target.h:76:2:  
> #error
> Unsupported system
> gmake[1]: *** [exec.o] Error 1
>
> Any help with this?

You need to add a conditional section for *BSD in that header file to  
define the call stack offset. Other ABI related changes in the source  
file may be necessary, too.

Andreas

Re: [Qemu-devel] QEMU TCG code does not build with OpenBSD PowerPC

[malc]

On Fri, 10 Apr 2009, Brad wrote:

> Trying to build on an OpenBSD PowerPC machine dies pretty quickly
> in the TCG PowerPC code..
> 
>    CC    i386-softmmu/exec.o
>  In file included from /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/tcg/tcg.h:24,
>                   from /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/exec.c:39:
>  /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/tcg/ppc/tcg-target.h:76:2: #error 
> Unsupported system
>  gmake[1]: *** [exec.o] Error 1
> 
> Any help with this?

You need to know which ABI OpenBSD/PPC uses. A shot in the dark would be
to try something like:

diff --git a/tcg/ppc/tcg-target.h b/tcg/ppc/tcg-target.h
index 5faf730..cd851a2 100644
--- a/tcg/ppc/tcg-target.h
+++ b/tcg/ppc/tcg-target.h
@@ -69,7 +69,7 @@ enum {
 #define TCG_TARGET_CALL_STACK_OFFSET 24
 #elif defined _AIX
 #define TCG_TARGET_CALL_STACK_OFFSET 52
-#elif defined __linux__
+#elif defined __linux__ || defined __OpenBSD__
 #define TCG_TARGET_CALL_ALIGN_ARGS 1
 #define TCG_TARGET_CALL_STACK_OFFSET 8
 #else


And similar changes in tcg-target.c..

-- 
mailto:av1474@comtv.ru

Re: [Qemu-devel] QEMU TCG code does not build with OpenBSD PowerPC

[Brad]

On Sat, Apr 11, 2009 at 10:58:06AM +0400, malc wrote:
> On Fri, 10 Apr 2009, Brad wrote:
> 
> > Trying to build on an OpenBSD PowerPC machine dies pretty quickly
> > in the TCG PowerPC code..
> > 
> >    CC    i386-softmmu/exec.o
> >  In file included from /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/tcg/tcg.h:24,
> >                   from /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/exec.c:39:
> >  /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/tcg/ppc/tcg-target.h:76:2: #error 
> > Unsupported system
> >  gmake[1]: *** [exec.o] Error 1
> > 
> > Any help with this?
> 
> You need to know which ABI OpenBSD/PPC uses. A shot in the dark would be
> to try something like:

After speaking to the PowerPC maintainer to double check, we're
using the standard SVR4 ABI so this should be good..

Also as far as I know this should also apply to FreeBSD and NetBSD
when running on PowerPC, but I'll leave it at this for now.


--- tcg/ppc/tcg-target.c.orig	Fri May  8 02:39:52 2009
+++ tcg/ppc/tcg-target.c	Fri May  8 02:41:24 2009
@@ -109,7 +109,7 @@ static const int tcg_target_reg_alloc_order[] = {
     TCG_REG_R11,
 #endif
     TCG_REG_R12,
-#ifndef __linux__
+#if !defined(__linux__) && !defined(__OpenBSD__)
     TCG_REG_R13,
 #endif
     TCG_REG_R0,
@@ -1535,7 +1535,7 @@ void tcg_target_init(TCGContext *s)
 #ifndef __APPLE__
     tcg_regset_set_reg(s->reserved_regs, TCG_REG_R2);
 #endif
-#ifdef __linux__
+#if defined(__linux__) || defined(__OpenBSD__)
     tcg_regset_set_reg(s->reserved_regs, TCG_REG_R13);
 #endif
 
--- tcg/ppc/tcg-target.h.orig	Mon Apr  6 22:04:47 2009
+++ tcg/ppc/tcg-target.h	Sun Apr 26 20:15:41 2009
@@ -69,7 +69,7 @@ enum {
 #define TCG_TARGET_CALL_STACK_OFFSET 24
 #elif defined _AIX
 #define TCG_TARGET_CALL_STACK_OFFSET 52
-#elif defined __linux__
+#elif defined __linux__ || defined __OpenBSD__
 #define TCG_TARGET_CALL_ALIGN_ARGS 1
 #define TCG_TARGET_CALL_STACK_OFFSET 8
 #else

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Re: [Qemu-devel] QEMU TCG code does not build with OpenBSD PowerPC

[malc]

On Sat, 9 May 2009, Brad wrote:

> On Sat, Apr 11, 2009 at 10:58:06AM +0400, malc wrote:
> > On Fri, 10 Apr 2009, Brad wrote:
> > 
> > > Trying to build on an OpenBSD PowerPC machine dies pretty quickly
> > > in the TCG PowerPC code..
> > > 
> > >    CC    i386-softmmu/exec.o
> > >  In file included from /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/tcg/tcg.h:24,
> > >                   from /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/exec.c:39:
> > >  /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/tcg/ppc/tcg-target.h:76:2: #error 
> > > Unsupported system
> > >  gmake[1]: *** [exec.o] Error 1
> > > 
> > > Any help with this?
> > 
> > You need to know which ABI OpenBSD/PPC uses. A shot in the dark would be
> > to try something like:
> 
> After speaking to the PowerPC maintainer to double check, we're
> using the standard SVR4 ABI so this should be good..
> 
> Also as far as I know this should also apply to FreeBSD and NetBSD
> when running on PowerPC, but I'll leave it at this for now.

Good.
 
> 
> --- tcg/ppc/tcg-target.c.orig	Fri May  8 02:39:52 2009
> +++ tcg/ppc/tcg-target.c	Fri May  8 02:41:24 2009
> @@ -109,7 +109,7 @@ static const int tcg_target_reg_alloc_order[] = {
>      TCG_REG_R11,
>  #endif
>      TCG_REG_R12,
> -#ifndef __linux__
> +#if !defined(__linux__) && !defined(__OpenBSD__)
>      TCG_REG_R13,
>  #endif
>      TCG_REG_R0,
> @@ -1535,7 +1535,7 @@ void tcg_target_init(TCGContext *s)
>  #ifndef __APPLE__
>      tcg_regset_set_reg(s->reserved_regs, TCG_REG_R2);
>  #endif
> -#ifdef __linux__
> +#if defined(__linux__) || defined(__OpenBSD__)
>      tcg_regset_set_reg(s->reserved_regs, TCG_REG_R13);
>  #endif
>  
> --- tcg/ppc/tcg-target.h.orig	Mon Apr  6 22:04:47 2009
> +++ tcg/ppc/tcg-target.h	Sun Apr 26 20:15:41 2009
> @@ -69,7 +69,7 @@ enum {
>  #define TCG_TARGET_CALL_STACK_OFFSET 24
>  #elif defined _AIX
>  #define TCG_TARGET_CALL_STACK_OFFSET 52
> -#elif defined __linux__
> +#elif defined __linux__ || defined __OpenBSD__
>  #define TCG_TARGET_CALL_ALIGN_ARGS 1
>  #define TCG_TARGET_CALL_STACK_OFFSET 8
>  #else

You tested this and it works?

-- 
mailto:av1474@comtv.ru

Re: [Qemu-devel] QEMU TCG code does not build with OpenBSD PowerPC

[Brad]

On Sunday 10 May 2009 14:41:13 malc wrote:
> On Sat, 9 May 2009, Brad wrote:
> > On Sat, Apr 11, 2009 at 10:58:06AM +0400, malc wrote:
> > > On Fri, 10 Apr 2009, Brad wrote:
> > > > Trying to build on an OpenBSD PowerPC machine dies pretty quickly
> > > > in the TCG PowerPC code..
> > > >
> > > >    CC    i386-softmmu/exec.o
> > > >  In file included from
> > > > /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/tcg/tcg.h:24, from
> > > > /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/exec.c:39:
> > > > /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/tcg/ppc/tcg-target.h:76:2:
> > > > #error Unsupported system
> > > >  gmake[1]: *** [exec.o] Error 1
> > > >
> > > > Any help with this?
> > >
> > > You need to know which ABI OpenBSD/PPC uses. A shot in the dark would
> > > be to try something like:
> >
> > After speaking to the PowerPC maintainer to double check, we're
> > using the standard SVR4 ABI so this should be good..
> >
> > Also as far as I know this should also apply to FreeBSD and NetBSD
> > when running on PowerPC, but I'll leave it at this for now.
>
> Good.
>
> > --- tcg/ppc/tcg-target.c.orig	Fri May  8 02:39:52 2009
> > +++ tcg/ppc/tcg-target.c	Fri May  8 02:41:24 2009
> > @@ -109,7 +109,7 @@ static const int tcg_target_reg_alloc_order[] = {
> >      TCG_REG_R11,
> >  #endif
> >      TCG_REG_R12,
> > -#ifndef __linux__
> > +#if !defined(__linux__) && !defined(__OpenBSD__)
> >      TCG_REG_R13,
> >  #endif
> >      TCG_REG_R0,
> > @@ -1535,7 +1535,7 @@ void tcg_target_init(TCGContext *s)
> >  #ifndef __APPLE__
> >      tcg_regset_set_reg(s->reserved_regs, TCG_REG_R2);
> >  #endif
> > -#ifdef __linux__
> > +#if defined(__linux__) || defined(__OpenBSD__)
> >      tcg_regset_set_reg(s->reserved_regs, TCG_REG_R13);
> >  #endif
> >
> > --- tcg/ppc/tcg-target.h.orig	Mon Apr  6 22:04:47 2009
> > +++ tcg/ppc/tcg-target.h	Sun Apr 26 20:15:41 2009
> > @@ -69,7 +69,7 @@ enum {
> >  #define TCG_TARGET_CALL_STACK_OFFSET 24
> >  #elif defined _AIX
> >  #define TCG_TARGET_CALL_STACK_OFFSET 52
> > -#elif defined __linux__
> > +#elif defined __linux__ || defined __OpenBSD__
> >  #define TCG_TARGET_CALL_ALIGN_ARGS 1
> >  #define TCG_TARGET_CALL_STACK_OFFSET 8
> >  #else
>
> You tested this and it works?

Its a moot point if it "works" since QEMU 0.10.x is broken on all archs
we had working with 0.9.x and QEMU 0.10.x is far from building as is.

So my first priority is to get it to even build properly on the archs we
supported with our 0.9.x port (amd64 i386 powerpc).

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Re: [Qemu-devel] QEMU TCG code does not build with OpenBSD PowerPC

[malc]

On Sun, 10 May 2009, Brad wrote:

> On Sunday 10 May 2009 14:41:13 malc wrote:
> > On Sat, 9 May 2009, Brad wrote:
> > > On Sat, Apr 11, 2009 at 10:58:06AM +0400, malc wrote:
> > > > On Fri, 10 Apr 2009, Brad wrote:

[..snip..]

> >
> > You tested this and it works?
> 
> Its a moot point if it "works" since QEMU 0.10.x is broken on all archs
> we had working with 0.9.x and QEMU 0.10.x is far from building as is.
> 
> So my first priority is to get it to even build properly on the archs we
> supported with our 0.9.x port (amd64 i386 powerpc).
> 

I see. I was under impression that Blue Swirl was building it successfully
on (at least) OpenBSD not so long ago. How is it broken?

-- 
mailto:av1474@comtv.ru

Re: [Qemu-devel] QEMU TCG code does not build with OpenBSD PowerPC

[M. Warner Losh]

In message: <Pine.LNX.4.64.0905102240440.2175@linmac.oyster.ru>
            malc <av1474@comtv.ru> writes:
: On Sat, 9 May 2009, Brad wrote:
: 
: > On Sat, Apr 11, 2009 at 10:58:06AM +0400, malc wrote:
: > > On Fri, 10 Apr 2009, Brad wrote:
: > > 
: > > > Trying to build on an OpenBSD PowerPC machine dies pretty quickly
: > > > in the TCG PowerPC code..
: > > > 
: > > >    CC    i386-softmmu/exec.o
: > > >  In file included from /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/tcg/tcg.h:24,
: > > >                   from /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/exec.c:39:
: > > >  /usr/obj/ports/qemu-0.10.2/qemu-0.10.2/tcg/ppc/tcg-target.h:76:2: #error 
: > > > Unsupported system
: > > >  gmake[1]: *** [exec.o] Error 1
: > > > 
: > > > Any help with this?
: > > 
: > > You need to know which ABI OpenBSD/PPC uses. A shot in the dark would be
: > > to try something like:
: > 
: > After speaking to the PowerPC maintainer to double check, we're
: > using the standard SVR4 ABI so this should be good..
: > 
: > Also as far as I know this should also apply to FreeBSD and NetBSD
: > when running on PowerPC, but I'll leave it at this for now.
: 
: Good.

I'm pretty sure that FreeBSD uses the SysV ABI, and not the newer
EABI.  I thought Linux was using the latter...

Warner

: > --- tcg/ppc/tcg-target.c.orig	Fri May  8 02:39:52 2009
: > +++ tcg/ppc/tcg-target.c	Fri May  8 02:41:24 2009
: > @@ -109,7 +109,7 @@ static const int tcg_target_reg_alloc_order[] = {
: >      TCG_REG_R11,
: >  #endif
: >      TCG_REG_R12,
: > -#ifndef __linux__
: > +#if !defined(__linux__) && !defined(__OpenBSD__)
: >      TCG_REG_R13,
: >  #endif
: >      TCG_REG_R0,
: > @@ -1535,7 +1535,7 @@ void tcg_target_init(TCGContext *s)
: >  #ifndef __APPLE__
: >      tcg_regset_set_reg(s->reserved_regs, TCG_REG_R2);
: >  #endif
: > -#ifdef __linux__
: > +#if defined(__linux__) || defined(__OpenBSD__)
: >      tcg_regset_set_reg(s->reserved_regs, TCG_REG_R13);
: >  #endif
: >  
: > --- tcg/ppc/tcg-target.h.orig	Mon Apr  6 22:04:47 2009
: > +++ tcg/ppc/tcg-target.h	Sun Apr 26 20:15:41 2009
: > @@ -69,7 +69,7 @@ enum {
: >  #define TCG_TARGET_CALL_STACK_OFFSET 24
: >  #elif defined _AIX
: >  #define TCG_TARGET_CALL_STACK_OFFSET 52
: > -#elif defined __linux__
: > +#elif defined __linux__ || defined __OpenBSD__
: >  #define TCG_TARGET_CALL_ALIGN_ARGS 1
: >  #define TCG_TARGET_CALL_STACK_OFFSET 8
: >  #else
: 
: You tested this and it works?
: 
: -- 
: mailto:av1474@comtv.ru
: 
: 
: 

Re: [Qemu-devel] QEMU TCG code does not build with OpenBSD PowerPC

[Blue Swirl]

On 5/11/09, malc <av1474@comtv.ru> wrote:
> On Sun, 10 May 2009, Brad wrote:
>
>  > On Sunday 10 May 2009 14:41:13 malc wrote:
>  > > On Sat, 9 May 2009, Brad wrote:
>  > > > On Sat, Apr 11, 2009 at 10:58:06AM +0400, malc wrote:
>  > > > > On Fri, 10 Apr 2009, Brad wrote:
>
>
> [..snip..]
>
>
>  > >
>  > > You tested this and it works?
>  >
>  > Its a moot point if it "works" since QEMU 0.10.x is broken on all archs
>  > we had working with 0.9.x and QEMU 0.10.x is far from building as is.
>  >
>  > So my first priority is to get it to even build properly on the archs we
>  > supported with our 0.9.x port (amd64 i386 powerpc).
>  >
>
>
> I see. I was under impression that Blue Swirl was building it successfully
>  on (at least) OpenBSD not so long ago. How is it broken?

QEMU works on OpenBSD/Sparc64 (at least sparc-softmmu is fine, other
targets I tested do not work well), and OpenBSD/Sparc32 did build at
some point. I had problems installing OpenBSD/i386 under QEMU, so I
haven't tested that.

Re: [Qemu-devel] QEMU TCG code does not build with OpenBSD PowerPC

[Brad]

On Monday 11 May 2009 11:30:09 Blue Swirl wrote:
> On 5/11/09, malc <av1474@comtv.ru> wrote:
> > On Sun, 10 May 2009, Brad wrote:
> >  > On Sunday 10 May 2009 14:41:13 malc wrote:
> >  > > On Sat, 9 May 2009, Brad wrote:
> >  > > > On Sat, Apr 11, 2009 at 10:58:06AM +0400, malc wrote:
> >  > > > > On Fri, 10 Apr 2009, Brad wrote:
> >
> > [..snip..]
> >
> >  > > You tested this and it works?
> >  >
> >  > Its a moot point if it "works" since QEMU 0.10.x is broken on all
> >  > archs we had working with 0.9.x and QEMU 0.10.x is far from building
> >  > as is.
> >  >
> >  > So my first priority is to get it to even build properly on the archs
> >  > we supported with our 0.9.x port (amd64 i386 powerpc).
> >
> > I see. I was under impression that Blue Swirl was building it
> > successfully on (at least) OpenBSD not so long ago. How is it broken?
>
> QEMU works on OpenBSD/Sparc64 (at least sparc-softmmu is fine, other
> targets I tested do not work well), and OpenBSD/Sparc32 did build at
> some point. I had problems installing OpenBSD/i386 under QEMU, so I
> haven't tested that.

And that's the problem. You tested the arch no one uses with QEMU (so far) 
instead of what is actually being used and the 0.10.x releases still don't 
even build there either.

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Re: [Qemu-devel] QEMU TCG code does not build with OpenBSD PowerPC

[Andreas Färber]

Am 11.05.2009 um 18:59 schrieb Brad:

> On Monday 11 May 2009 11:30:09 Blue Swirl wrote:
>> On 5/11/09, malc <av1474@comtv.ru> wrote:
>>> On Sun, 10 May 2009, Brad wrote:
>>>> On Sunday 10 May 2009 14:41:13 malc wrote:
>>>>> On Sat, 9 May 2009, Brad wrote:
>>>>>> On Sat, Apr 11, 2009 at 10:58:06AM +0400, malc wrote:
>>>>>>> On Fri, 10 Apr 2009, Brad wrote:
>>>
>>> [..snip..]
>>>
>>>>> You tested this and it works?
>>>>
>>>> Its a moot point if it "works" since QEMU 0.10.x is broken on all
>>>> archs we had working with 0.9.x and QEMU 0.10.x is far from  
>>>> building
>>>> as is.
>>>>
>>>> So my first priority is to get it to even build properly on the  
>>>> archs
>>>> we supported with our 0.9.x port (amd64 i386 powerpc).
>>>
>>> I see. I was under impression that Blue Swirl was building it
>>> successfully on (at least) OpenBSD not so long ago. How is it  
>>> broken?
>>
>> QEMU works on OpenBSD/Sparc64 (at least sparc-softmmu is fine, other
>> targets I tested do not work well), and OpenBSD/Sparc32 did build at
>> some point. I had problems installing OpenBSD/i386 under QEMU, so I
>> haven't tested that.
>
> And that's the problem. You tested the arch no one uses with QEMU  
> (so far)
> instead of what is actually being used and the 0.10.x releases still  
> don't
> even build there either.

No, it's not. The real problem is that following the fourth 0.10.x  
release, previously unknown port maintainers come popping up and  
complaining, rather than providing patches against the SVN/Git version  
before the release is made.
Which means that no OpenBSD/i386 user cared for an estimated year -  
don't blame Blue for that.

Without you telling us the exact build errors you get it's really hard  
to help you...

Andreas

Re: [Qemu-devel] QEMU TCG code does not build with OpenBSD PowerPC

[Blue Swirl]

On 5/11/09, Brad <brad@comstyle.com> wrote:
> On Monday 11 May 2009 11:30:09 Blue Swirl wrote:
>  > On 5/11/09, malc <av1474@comtv.ru> wrote:
>  > > On Sun, 10 May 2009, Brad wrote:
>  > >  > On Sunday 10 May 2009 14:41:13 malc wrote:
>  > >  > > On Sat, 9 May 2009, Brad wrote:
>  > >  > > > On Sat, Apr 11, 2009 at 10:58:06AM +0400, malc wrote:
>  > >  > > > > On Fri, 10 Apr 2009, Brad wrote:
>  > >
>  > > [..snip..]
>  > >
>  > >  > > You tested this and it works?
>  > >  >
>  > >  > Its a moot point if it "works" since QEMU 0.10.x is broken on all
>  > >  > archs we had working with 0.9.x and QEMU 0.10.x is far from building
>  > >  > as is.
>  > >  >
>  > >  > So my first priority is to get it to even build properly on the archs
>  > >  > we supported with our 0.9.x port (amd64 i386 powerpc).
>  > >
>  > > I see. I was under impression that Blue Swirl was building it
>  > > successfully on (at least) OpenBSD not so long ago. How is it broken?
>  >
>  > QEMU works on OpenBSD/Sparc64 (at least sparc-softmmu is fine, other
>  > targets I tested do not work well), and OpenBSD/Sparc32 did build at
>  > some point. I had problems installing OpenBSD/i386 under QEMU, so I
>  > haven't tested that.
>
>
> And that's the problem. You tested the arch no one uses with QEMU (so far)
>  instead of what is actually being used and the 0.10.x releases still don't
>  even build there either.

Well, the only real machine I have with OpenBSD is Sparc64 and
OpenBSD/x86 did not want install under QEMU.