From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LsI9R-0006Tg-Ex for qemu-devel@nongnu.org; Fri, 10 Apr 2009 10:56:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LsI9P-0006R7-KQ for qemu-devel@nongnu.org; Fri, 10 Apr 2009 10:56:16 -0400 Received: from [199.232.76.173] (port=37175 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LsI9P-0006Qu-DL for qemu-devel@nongnu.org; Fri, 10 Apr 2009 10:56:15 -0400 Received: from hall.aurel32.net ([88.191.82.174]:36525) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LsI9O-0002xJ-UC for qemu-devel@nongnu.org; Fri, 10 Apr 2009 10:56:15 -0400 Date: Fri, 10 Apr 2009 16:56:09 +0200 From: Aurelien Jarno Subject: Re: [Qemu-devel] [RFC][PATCH] tcg: allocate memory to spill registers on startup Message-ID: <20090410145609.GA20999@volta.aurel32.net> References: <20090410085406.GA15094@volta.aurel32.net> <200904101544.56081.paul@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200904101544.56081.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org On Fri, Apr 10, 2009 at 03:44:55PM +0100, Paul Brook wrote: > On Friday 10 April 2009, Aurelien Jarno wrote: > > +    assert(size != TCG_MAX_TEMPS * sizeof(tcg_target_long)); > > Shouldn't this be >= ? > When I wrote that, I thought that the two sizes have to match, but you are right, the frame size can actually be bigger. Any other comment? -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net