From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LsJO7-0007dG-93 for qemu-devel@nongnu.org; Fri, 10 Apr 2009 12:15:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LsJO2-0007bL-Em for qemu-devel@nongnu.org; Fri, 10 Apr 2009 12:15:30 -0400 Received: from [199.232.76.173] (port=38677 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LsJO2-0007bD-93 for qemu-devel@nongnu.org; Fri, 10 Apr 2009 12:15:26 -0400 Received: from verein.lst.de ([213.95.11.210]:46560) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1LsJO1-0004pN-SN for qemu-devel@nongnu.org; Fri, 10 Apr 2009 12:15:26 -0400 Date: Fri, 10 Apr 2009 18:15:23 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH] qemu-io: Verify read data by patterns Message-ID: <20090410161523.GB8452@lst.de> References: <1239284776-2115-1-git-send-email-kwolf@redhat.com> <20090409153314.GB22492@lst.de> <200904091907.45921@kevin-wolf.de> <49DE3641.9090900@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49DE3641.9090900@codemonkey.ws> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Christoph Hellwig On Thu, Apr 09, 2009 at 12:54:09PM -0500, Anthony Liguori wrote: > The only reason I merged it as-is is because the code was derived from > something else. I didn't want to force a reindentation that would make > it harder to keep the code synced against the upstream project. The one where I really don't want to change it is cmd.[ch] as it's a 1:1 copy from libxcmd. While qemu-io.c is derived from xfs_io it already has diverged a lot and will even more.