From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LsOnH-00022B-Cs for qemu-devel@nongnu.org; Fri, 10 Apr 2009 18:01:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LsOnG-00021i-PL for qemu-devel@nongnu.org; Fri, 10 Apr 2009 18:01:50 -0400 Received: from [199.232.76.173] (port=46680 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LsOnG-00021f-GT for qemu-devel@nongnu.org; Fri, 10 Apr 2009 18:01:50 -0400 Received: from hall.aurel32.net ([88.191.82.174]:40285) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LsOnF-0007eX-RT for qemu-devel@nongnu.org; Fri, 10 Apr 2009 18:01:50 -0400 Date: Fri, 10 Apr 2009 23:55:40 +0200 From: =?iso-8859-15?Q?Aur=E9lien?= Jarno Subject: Re: [Qemu-devel] [7076] target-mips: optimize a few tcg_temp_free() Message-ID: <20090410215540.GA18746@volta.aurel32.net> References: <0246F9D1-B455-4A9D-86C1-46E620E47391@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0246F9D1-B455-4A9D-86C1-46E620E47391@web.de> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-15?Q?F=E4rber?= Cc: qemu-devel@nongnu.org On Fri, Apr 10, 2009 at 11:48:57PM +0200, Andreas Färber wrote: > > Am 10.04.2009 um 23:41 schrieb Aurelien Jarno: > >> @@ -5860,11 +5860,11 @@ >> >> tcg_gen_andi_i32(t0, fpu_fcr31, get_fp_bit(cc+1)); >> tcg_gen_brcondi_i32(cond, t0, 0, l2); >> + tcg_temp_free_i32(t0); >> gen_load_fpr32h(t0, fs); >> gen_store_fpr32h(t0, fd); > > Use after free? Oops, I think I should stop writing code now and go to sleep instead. Thanks for the notice. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net