From: Kevin Wolf <mail@kevin-wolf.de>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH] qemu-io: Verify read data by patterns
Date: Fri, 10 Apr 2009 22:18:11 +0200 [thread overview]
Message-ID: <200904102218.11800@kevin-wolf.de> (raw)
In-Reply-To: <20090410161403.GA8452@lst.de>
Am Freitag, 10. April 2009 18:14 schrieb Christoph Hellwig:
> On Thu, Apr 09, 2009 at 07:07:45PM +0200, Kevin Wolf wrote:
> > I considered that, but actually it's not a simple flag anymore as soon as
> > it has a parameter. Don't know, you could argue either way.
>
> We have it that way in writev. I don't really care too much either way,
> but I do care for consistency between the individual commands.
Sure, this is a good point. I can't see the Pflag in writev though, you just
change the default pattern if -P is specified.
Anyway, we're discussing details. I'll change the name to Pflag and the line
break so that it works with eight character tabs. Anything else to do before
it could be merged?
Kevin
next prev parent reply other threads:[~2009-04-10 20:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 13:46 [Qemu-devel] [PATCH] qemu-io: Verify read data by patterns Kevin Wolf
2009-04-09 15:33 ` Christoph Hellwig
2009-04-09 17:07 ` Kevin Wolf
2009-04-09 17:15 ` Christoph Hellwig
2009-04-09 17:54 ` Anthony Liguori
2009-04-09 18:55 ` Kevin Wolf
2009-04-10 16:15 ` Christoph Hellwig
2009-04-10 20:23 ` Kevin Wolf
2009-04-10 16:14 ` Christoph Hellwig
2009-04-10 20:18 ` Kevin Wolf [this message]
2009-04-12 4:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904102218.11800@kevin-wolf.de \
--to=mail@kevin-wolf.de \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).