From: Kevin Wolf <mail@kevin-wolf.de>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH] qemu-io: Verify read data by patterns
Date: Fri, 10 Apr 2009 22:23:18 +0200 [thread overview]
Message-ID: <200904102223.18564@kevin-wolf.de> (raw)
In-Reply-To: <20090410161523.GB8452@lst.de>
Am Freitag, 10. April 2009 18:15 schrieb Christoph Hellwig:
> On Thu, Apr 09, 2009 at 12:54:09PM -0500, Anthony Liguori wrote:
> > The only reason I merged it as-is is because the code was derived from
> > something else. I didn't want to force a reindentation that would make
> > it harder to keep the code synced against the upstream project.
>
> The one where I really don't want to change it is cmd.[ch] as it's a 1:1
> copy from libxcmd. While qemu-io.c is derived from xfs_io it already
> has diverged a lot and will even more.
Sounds like a good idea then to convert qemu-io.c and leave the rest as it is.
I guess that cmd.[ch] won't be changed too often compared to qemu-io.c, so
it's much less annoying there.
Anthony, would you accept a patch converting tabs to spaces in qemu-io.c? Or
maybe you want to do it yourself?
Kevin
next prev parent reply other threads:[~2009-04-10 20:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 13:46 [Qemu-devel] [PATCH] qemu-io: Verify read data by patterns Kevin Wolf
2009-04-09 15:33 ` Christoph Hellwig
2009-04-09 17:07 ` Kevin Wolf
2009-04-09 17:15 ` Christoph Hellwig
2009-04-09 17:54 ` Anthony Liguori
2009-04-09 18:55 ` Kevin Wolf
2009-04-10 16:15 ` Christoph Hellwig
2009-04-10 20:23 ` Kevin Wolf [this message]
2009-04-10 16:14 ` Christoph Hellwig
2009-04-10 20:18 ` Kevin Wolf
2009-04-12 4:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904102223.18564@kevin-wolf.de \
--to=mail@kevin-wolf.de \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).