From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LsNHB-0005Zw-EF
	for qemu-devel@nongnu.org; Fri, 10 Apr 2009 16:24:37 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LsNH6-0005YY-8J
	for qemu-devel@nongnu.org; Fri, 10 Apr 2009 16:24:36 -0400
Received: from [199.232.76.173] (port=33810 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LsNH6-0005YT-0t
	for qemu-devel@nongnu.org; Fri, 10 Apr 2009 16:24:32 -0400
Received: from mo-p00-ob.rzone.de ([81.169.146.161]:27073)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mail@kevin-wolf.de>) id 1LsNH5-0007sg-Mn
	for qemu-devel@nongnu.org; Fri, 10 Apr 2009 16:24:31 -0400
From: Kevin Wolf <mail@kevin-wolf.de>
Subject: Re: [Qemu-devel] [PATCH] qemu-io: Verify read data by patterns
Date: Fri, 10 Apr 2009 22:23:18 +0200
References: <1239284776-2115-1-git-send-email-kwolf@redhat.com>
	<49DE3641.9090900@codemonkey.ws> <20090410161523.GB8452@lst.de>
In-Reply-To: <20090410161523.GB8452@lst.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200904102223.18564@kevin-wolf.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Christoph Hellwig <hch@lst.de>

Am Freitag, 10. April 2009 18:15 schrieb Christoph Hellwig:
> On Thu, Apr 09, 2009 at 12:54:09PM -0500, Anthony Liguori wrote:
> > The only reason I merged it as-is is because the code was derived from
> > something else.  I didn't want to force a reindentation that would make
> > it harder to keep the code synced against the upstream project.
>
> The one where I really don't want to change it is cmd.[ch] as it's a 1:1
> copy from libxcmd.  While qemu-io.c is derived from xfs_io it already
> has diverged a lot and will even more.

Sounds like a good idea then to convert qemu-io.c and leave the rest as it is. 
I guess that cmd.[ch] won't be changed too often compared to qemu-io.c, so 
it's much less annoying there.

Anthony, would you accept a patch converting tabs to spaces in qemu-io.c? Or 
maybe you want to do it yourself?

Kevin