From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lsr9d-0004cv-Vt
	for qemu-devel@nongnu.org; Sun, 12 Apr 2009 00:18:50 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lsr9Z-0004am-BC
	for qemu-devel@nongnu.org; Sun, 12 Apr 2009 00:18:49 -0400
Received: from [199.232.76.173] (port=34867 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lsr9Z-0004aj-44
	for qemu-devel@nongnu.org; Sun, 12 Apr 2009 00:18:45 -0400
Received: from verein.lst.de ([213.95.11.210]:40122)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1Lsr9Y-000855-NQ
	for qemu-devel@nongnu.org; Sun, 12 Apr 2009 00:18:45 -0400
Date: Sun, 12 Apr 2009 06:18:40 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH] qemu-io: Verify read data by patterns
Message-ID: <20090412041840.GA9574@lst.de>
References: <1239284776-2115-1-git-send-email-kwolf@redhat.com>
	<200904091907.45921@kevin-wolf.de> <20090410161403.GA8452@lst.de>
	<200904102218.11800@kevin-wolf.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200904102218.11800@kevin-wolf.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <mail@kevin-wolf.de>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Christoph Hellwig <hch@lst.de>

On Fri, Apr 10, 2009 at 10:18:11PM +0200, Kevin Wolf wrote:
> Sure, this is a good point. I can't see the Pflag in writev though, you just 
> change the default pattern if -P is specified.
> 
> Anyway, we're discussing details. I'll change the name to Pflag and the line 
> break so that it works with eight character tabs.  Anything else to do before 
> it could be merged?

I don't think there's anything else, it looks good in general.