From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [patch 2/2] qemu: switch pci device init functions to accept devfn
Date: Mon, 13 Apr 2009 13:27:34 +0100 [thread overview]
Message-ID: <200904131327.35201.paul@codesourcery.com> (raw)
In-Reply-To: <20090413035340.296329700@amt.cnet>
On Monday 13 April 2009, Marcelo Tosatti wrote:
> Some pci device initialization functions do not accept a devfn parameter,
> but instead use "-1", which caused pci_register_device to find the first
> free slot on the given bus.
>
> Have them accept a "devfn" parameter, and use the newly introduced
> pci_bus_assign_dev_addr function on platform init code to perform
> the "first free" enumeration.
I don't see how this is better. If anything we want the platform code to get
smaller, not larger.
Paul
next prev parent reply other threads:[~2009-04-13 12:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-13 3:53 [Qemu-devel] [patch 0/2] RFC: move PCI device enumeration out of pci drivers Marcelo Tosatti
2009-04-13 3:53 ` [Qemu-devel] [patch 1/2] qemu: move pci devfn "first free" assignment to separate function Marcelo Tosatti
2009-04-13 8:08 ` Avi Kivity
2009-04-13 3:53 ` [Qemu-devel] [patch 2/2] qemu: switch pci device init functions to accept devfn Marcelo Tosatti
2009-04-13 12:27 ` Paul Brook [this message]
2009-04-13 13:30 ` Marcelo Tosatti
2009-04-13 13:47 ` Brian Wheeler
2009-04-13 14:34 ` Marcelo Tosatti
2009-04-14 3:29 ` Marcelo Tosatti
2009-04-14 8:17 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904131327.35201.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=armbru@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).