From: Christoph Hellwig <hch@lst.de>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] implement qemu_blockalign
Date: Tue, 14 Apr 2009 18:24:54 +0200 [thread overview]
Message-ID: <20090414162454.GA11708@lst.de> (raw)
In-Reply-To: <49E35345.1090004@eu.citrix.com>
On Mon, Apr 13, 2009 at 03:59:17PM +0100, Stefano Stabellini wrote:
> +
> +void *qemu_blockalign(BlockDriverState *bs, size_t size)
The function could use a comment..
> int growable;
>
> + /* the memory alignment required for the buffers handled by this driver */
It's not the required alignment, but the preffered one.
next prev parent reply other threads:[~2009-04-14 16:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-13 14:59 [Qemu-devel] [PATCH] implement qemu_blockalign Stefano Stabellini
2009-04-14 16:24 ` Christoph Hellwig [this message]
2009-04-14 17:03 ` Stefano Stabellini
2009-04-22 20:22 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090414162454.GA11708@lst.de \
--to=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).