From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LtlRY-00045M-Sg
	for qemu-devel@nongnu.org; Tue, 14 Apr 2009 12:25:04 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LtlRU-00044N-6j
	for qemu-devel@nongnu.org; Tue, 14 Apr 2009 12:25:04 -0400
Received: from [199.232.76.173] (port=58655 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LtlRU-00044K-3u
	for qemu-devel@nongnu.org; Tue, 14 Apr 2009 12:25:00 -0400
Received: from verein.lst.de ([213.95.11.210]:54265)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1LtlRT-0006eV-76
	for qemu-devel@nongnu.org; Tue, 14 Apr 2009 12:24:59 -0400
Received: from verein.lst.de (localhost [127.0.0.1])
	by verein.lst.de (8.12.3/8.12.3/Debian-7.1) with ESMTP id
	n3EGOsIF011760
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO)
	for <qemu-devel@nongnu.org>; Tue, 14 Apr 2009 18:24:55 +0200
Received: (from hch@localhost)
	by verein.lst.de (8.12.3/8.12.3/Debian-6.6) id n3EGOskp011758
	for qemu-devel@nongnu.org; Tue, 14 Apr 2009 18:24:54 +0200
Date: Tue, 14 Apr 2009 18:24:54 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH] implement qemu_blockalign
Message-ID: <20090414162454.GA11708@lst.de>
References: <49E35345.1090004@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <49E35345.1090004@eu.citrix.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Mon, Apr 13, 2009 at 03:59:17PM +0100, Stefano Stabellini wrote:
> +
> +void *qemu_blockalign(BlockDriverState *bs, size_t size)

The function could use a comment..

>      int growable;
>  
> +    /* the memory alignment required for the buffers handled by this driver */

It's not the required alignment, but the preffered one.