From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LuIFO-0007qv-Ey for qemu-devel@nongnu.org; Wed, 15 Apr 2009 23:26:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LuIFJ-0007qY-Ps for qemu-devel@nongnu.org; Wed, 15 Apr 2009 23:26:42 -0400 Received: from [199.232.76.173] (port=43040 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LuIFJ-0007qU-Ji for qemu-devel@nongnu.org; Wed, 15 Apr 2009 23:26:37 -0400 Received: from bsdimp.com ([199.45.160.85]:55539 helo=harmony.bsdimp.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LuIFI-00042E-Ve for qemu-devel@nongnu.org; Wed, 15 Apr 2009 23:26:37 -0400 Date: Wed, 15 Apr 2009 21:24:44 -0600 (MDT) Message-Id: <20090415.212444.-1306033391.imp@bsdimp.com> Subject: Re: [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup() From: "M. Warner Losh" In-Reply-To: <20090416010725.GA24264@amt.cnet> References: <1239812969-8320-10-git-send-email-markmc@redhat.com> <49E61A9D.2060605@siemens.com> <20090416010725.GA24264@amt.cnet> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, mtosatti@redhat.com Cc: markmc@redhat.com, aliguori@us.ibm.com, armbru@redhat.com In message: <20090416010725.GA24264@amt.cnet> Marcelo Tosatti writes: : > > +static void isa_ne2000_cleanup(VLANClientState *vc) : > > +{ : > > + NE2000State *s = vc->opaque; : > > + : > > + unregister_savevm("ne2000", s); : > > + : > > + isa_unassign_ioport(s->isa_io_base, 16); : > > + isa_unassign_ioport(s->isa_io_base + 0x10, 2); : > > + isa_unassign_ioport(s->isa_io_base + 0x1f, 1); : > > + : > > + qemu_free(s); : > > +} : > Hot-plugging ISA device - scary... :) : : Yeah :) No it isn't. They called it PC Card (aka PCMCIA) back in the day :) Warner