From: Kevin Wolf <mail@kevin-wolf.de>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount()
Date: Fri, 17 Apr 2009 23:00:34 +0200 [thread overview]
Message-ID: <200904172300.34596@kevin-wolf.de> (raw)
In-Reply-To: <49E8E8E7.2000407@us.ibm.com>
Hi Anthony,
Am Freitag, 17. April 2009 22:39 schrieb Anthony Liguori:
> Do you have a qemu-io script handy that can be used to stress something
> like this patch set? After the last qcow2 regression, I'm wary of
> additional cleanups that we can't validate with a strong stress test.
This patch series is harmless in that respect. You can tell alone from looking
at the patches that it can't cause regressions in normal operation, because
it only touches code which was previosuly not even built and is only called
by qemu-img (after patch 3) and when DEBUG_ALLOC is defined.
But you would better apply the corruption fix I sent on Wednesday. ;-)
And even though I think that this series can't break anything, we definitely
could use a strong test suite. I'm almost sure that there is at least one bug
left (the one Jamie Lokier saw from 5006 on, but nobody ever found it).
Kevin
next prev parent reply other threads:[~2009-04-17 21:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 12:04 [Qemu-devel] [PATCH 0/5] Add qemu-img check subcommand Kevin Wolf
2009-04-17 12:40 ` [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount() Kevin Wolf
2009-04-17 14:01 ` kwolf
2009-04-17 20:39 ` Anthony Liguori
2009-04-17 21:00 ` Kevin Wolf [this message]
2009-04-17 21:03 ` Anthony Liguori
2009-04-17 21:19 ` Kevin Wolf
2009-04-17 22:07 ` Anthony Liguori
2009-04-17 22:29 ` Kevin Wolf
2009-04-17 22:31 ` Anthony Liguori
2009-04-18 0:11 ` Ryan Harper
2009-04-20 13:48 ` Christoph Hellwig
2009-04-21 16:19 ` Kevin Wolf
2009-04-20 13:46 ` Christoph Hellwig
2009-04-21 23:12 ` Anthony Liguori
2009-04-17 14:01 ` [Qemu-devel] [PATCH 2/5] Introduce bdrv_check kwolf
2009-04-17 14:01 ` [Qemu-devel] [PATCH 3/5] Introduce qemu-img check subcommand kwolf
2009-04-17 14:01 ` [Qemu-devel] [PATCH 4/5] qcow2: Refcount checking code cleanup kwolf
2009-04-21 8:32 ` [Qemu-devel] [PATCH v2 " Kevin Wolf
2009-04-17 14:02 ` [Qemu-devel] [PATCH 5/5] qcow2: Add plausibility check for L1/L2 entries kwolf
2009-04-20 10:30 ` [Qemu-devel] [PATCH 0/5] Add qemu-img check subcommand Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904172300.34596@kevin-wolf.de \
--to=mail@kevin-wolf.de \
--cc=aliguori@us.ibm.com \
--cc=hch@infradead.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).