From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LuvBu-0006Tp-4k
	for qemu-devel@nongnu.org; Fri, 17 Apr 2009 17:01:42 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LuvBp-0006Rr-Ks
	for qemu-devel@nongnu.org; Fri, 17 Apr 2009 17:01:41 -0400
Received: from [199.232.76.173] (port=58363 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LuvBp-0006Ro-Hh
	for qemu-devel@nongnu.org; Fri, 17 Apr 2009 17:01:37 -0400
Received: from mo-p00-ob.rzone.de ([81.169.146.160]:18843)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mail@kevin-wolf.de>) id 1LuvBp-0000V3-0n
	for qemu-devel@nongnu.org; Fri, 17 Apr 2009 17:01:37 -0400
From: Kevin Wolf <mail@kevin-wolf.de>
Subject: Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount()
Date: Fri, 17 Apr 2009 23:00:34 +0200
References: <1239969879-5611-1-git-send-email-kwolf@redhat.com>
	<1239976920-4912-1-git-send-email-kwolf@redhat.com>
	<49E8E8E7.2000407@us.ibm.com>
In-Reply-To: <49E8E8E7.2000407@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200904172300.34596@kevin-wolf.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Christoph Hellwig <hch@infradead.org>, Anthony Liguori <aliguori@us.ibm.com>

Hi Anthony,

Am Freitag, 17. April 2009 22:39 schrieb Anthony Liguori:
> Do you have a qemu-io script handy that can be used to stress something
> like this patch set?  After the last qcow2 regression, I'm wary of
> additional cleanups that we can't validate with a strong stress test.

This patch series is harmless in that respect. You can tell alone from looking 
at the patches that it can't cause regressions in normal operation, because 
it only touches code which was previosuly not even built and is only called 
by qemu-img (after patch 3) and when DEBUG_ALLOC is defined.

But you would better apply the corruption fix I sent on Wednesday. ;-)

And even though I think that this series can't break anything, we definitely 
could use a strong test suite. I'm almost sure that there is at least one bug 
left (the one Jamie Lokier saw from 5006 on, but nobody ever found it).

Kevin