From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Luy9Q-0002PX-R9 for qemu-devel@nongnu.org; Fri, 17 Apr 2009 20:11:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Luy9M-0002PD-PM for qemu-devel@nongnu.org; Fri, 17 Apr 2009 20:11:20 -0400 Received: from [199.232.76.173] (port=36372 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Luy9M-0002PA-MM for qemu-devel@nongnu.org; Fri, 17 Apr 2009 20:11:16 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:58639) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Luy9M-0004UG-BE for qemu-devel@nongnu.org; Fri, 17 Apr 2009 20:11:16 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e34.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n3I08pc1007654 for ; Fri, 17 Apr 2009 18:08:51 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3I0BCg2210828 for ; Fri, 17 Apr 2009 18:11:12 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3I0BBap023485 for ; Fri, 17 Apr 2009 18:11:12 -0600 Date: Fri, 17 Apr 2009 19:11:11 -0500 From: Ryan Harper Subject: Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount() Message-ID: <20090418001111.GG25977@us.ibm.com> References: <1239969879-5611-1-git-send-email-kwolf@redhat.com> <200904172319.55735@kevin-wolf.de> <49E8FDA1.2030505@us.ibm.com> <200904180029.06432@kevin-wolf.de> <49E90356.1090305@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49E90356.1090305@us.ibm.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , Christoph Hellwig , Kevin Wolf , qemu-devel@nongnu.org * Anthony Liguori [2009-04-17 17:38]: > Kevin Wolf wrote: > >Am Samstag, 18. April 2009 00:07 schrieben Sie: > > > >>Every patch I commit gets tested. I have various tests that I run > >>depending on which subsystem the patch touches. Right now, for qcow2, I > >>don't have nearly enough. I was hoping that Christoph had something > >>laying around that I could use since it looks like qemu-io would be a > >>great harness for qcow2 changes. > >> > > > >It is, definitely. qemu-io is the other part which I needed. But qemu-io > >alone won't make you happy. It can exercise a lot of code, but it can't > >tell you if your image is broken in the end. Except for reading back > >written data, of course, but breakage is often enough more subtle. > > > > > >>But I can write a pretty easy script myself on top of qemu-io so it's no > >>big deal. I'm not suggesting holding up development. > >> > > > >Heh, so everyone is writing his own scripts. What would you think about > >bringing the test cases you use into the repository? > > > > Yeah, I've been wanting to do everything via kvm-autotest but so far, > it's not quite up to what I want to use it for. I'll see about cleaning > up some of my scripts and posting them. The problem is they rely on > custom images. If you post em, I'm sure we can work it in. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ryanh@us.ibm.com