From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lvqlt-00025R-AL
	for qemu-devel@nongnu.org; Mon, 20 Apr 2009 06:30:41 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lvqlo-00023K-Ki
	for qemu-devel@nongnu.org; Mon, 20 Apr 2009 06:30:40 -0400
Received: from [199.232.76.173] (port=51544 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lvqlo-00023H-F2
	for qemu-devel@nongnu.org; Mon, 20 Apr 2009 06:30:36 -0400
Received: from mx2.redhat.com ([66.187.237.31]:45226)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1Lvqln-0005V4-6x
	for qemu-devel@nongnu.org; Mon, 20 Apr 2009 06:30:35 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n3KAUW4F019828
	for <qemu-devel@nongnu.org>; Mon, 20 Apr 2009 06:30:32 -0400
Date: Mon, 20 Apr 2009 13:30:30 +0300
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/5] Add qemu-img check subcommand
Message-ID: <20090420103030.GV10126@redhat.com>
References: <1239969879-5611-1-git-send-email-kwolf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1239969879-5611-1-git-send-email-kwolf@redhat.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>

On Fri, Apr 17, 2009 at 02:04:34PM +0200, Kevin Wolf wrote:
> Current qcow2 code already includes some functions to do some consistency
> checks (e.g. compare refcounts to real usage). Allowing the user (or developer
> debugging qcow2 code) to check his images only involves actually building this
> code and exposing it to the user by qemu-img.
> 
> This patch series implements a check subcommand for qemu-img. I think it will
> be useful especially in combination with qemu-io for test suites.
> 
Qumranet's product had this functionality and I found it to be so useful
that I still have qemu-img binary that has this "check" verb. For
instance if windows starts to BSOD to often the first thing I do is to
check that image is not corrupted.

> Kevin
> 
> Kevin Wolf (5):
>   qcow2: Fix warnings in check_refcount()
>   Introduce bdrv_check
>   Introduce qemu-img check subcommand
>   qcow2: Refcount checking code cleanup
>   qcow2: Add plausibility check for L1/L2 entries
> 
>  block-qcow2.c |  239 +++++++++++++++++++++++++++++++++++++++++---------------
>  block.c       |   14 ++++
>  block.h       |    1 +
>  block_int.h   |    3 +
>  qemu-img.c    |   62 +++++++++++++++
>  5 files changed, 255 insertions(+), 64 deletions(-)
> 
> 

--
			Gleb.