qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] Rework -boot option
Date: Mon, 20 Apr 2009 19:38:21 +0100	[thread overview]
Message-ID: <20090420183821.GA29116@redhat.com> (raw)
In-Reply-To: <49ECB940.5060100@codemonkey.ws>

On Mon, Apr 20, 2009 at 01:04:48PM -0500, Anthony Liguori wrote:
> Jan Kiszka wrote:
> >This patch changes the boot command line option to the canonical format
> >
> > -boot [order=drives][,interactive=on|off]
> >
> >where 'drives' is using the same format as the old -boot. The new format
> >is required in order to add the 'interactive' option and use the
> >existing infrastructure to parse it.
> >
> >The state of 'interactive' is transfered to the firmware via the new
> >configuration value FW_CFG_BOOT_INTERACTIVE.
> >
> >Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >  
> 
> This breaks compatibility with existing management tools.  Can't we do:
> 
> -boot [order=]drives[,interactive=on|off]
> 
> Certainly, -drive introduces a precedence for this type of format.

The 'order=' seems a little overkill - just leave it out entirely,
just having:

  -boot drives,interactive=on|off

which is fully back-compatible too.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

      parent reply	other threads:[~2009-04-20 18:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-20 17:05 [Qemu-devel] [PATCH 1/2] Rework -boot option Jan Kiszka
2009-04-20 18:04 ` Anthony Liguori
2009-04-20 18:34   ` [Qemu-devel] " Jan Kiszka
2009-04-20 18:41     ` Avi Kivity
2009-04-20 20:01       ` [Qemu-devel] [PATCH 1/2 -v] " Jan Kiszka
2009-04-20 19:13     ` [Qemu-devel] Re: [PATCH 1/2] " Anthony Liguori
2009-04-20 18:38   ` Daniel P. Berrange [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090420183821.GA29116@redhat.com \
    --to=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).