From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LvyNz-0006W4-GP for qemu-devel@nongnu.org; Mon, 20 Apr 2009 14:38:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LvyNv-0006V6-10 for qemu-devel@nongnu.org; Mon, 20 Apr 2009 14:38:31 -0400 Received: from [199.232.76.173] (port=42855 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LvyNu-0006V3-Rx for qemu-devel@nongnu.org; Mon, 20 Apr 2009 14:38:26 -0400 Received: from mx1.redhat.com ([66.187.233.31]:55443) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LvyNu-00046v-A1 for qemu-devel@nongnu.org; Mon, 20 Apr 2009 14:38:26 -0400 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n3KIcMZm025210 for ; Mon, 20 Apr 2009 14:38:22 -0400 Received: from file.fab.redhat.com (file.fab.redhat.com [10.33.63.6]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n3KIcLK2004060 for ; Mon, 20 Apr 2009 14:38:22 -0400 Received: from file.fab.redhat.com (localhost.localdomain [127.0.0.1]) by file.fab.redhat.com (8.13.1/8.13.1) with ESMTP id n3KIcLtG010275 for ; Mon, 20 Apr 2009 19:38:21 +0100 Received: (from berrange@localhost) by file.fab.redhat.com (8.13.1/8.13.1/Submit) id n3KIcLFW010271 for qemu-devel@nongnu.org; Mon, 20 Apr 2009 19:38:21 +0100 Date: Mon, 20 Apr 2009 19:38:21 +0100 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH 1/2] Rework -boot option Message-ID: <20090420183821.GA29116@redhat.com> References: <49ECAB4A.2090106@siemens.com> <49ECB940.5060100@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49ECB940.5060100@codemonkey.ws> Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Mon, Apr 20, 2009 at 01:04:48PM -0500, Anthony Liguori wrote: > Jan Kiszka wrote: > >This patch changes the boot command line option to the canonical format > > > > -boot [order=drives][,interactive=on|off] > > > >where 'drives' is using the same format as the old -boot. The new format > >is required in order to add the 'interactive' option and use the > >existing infrastructure to parse it. > > > >The state of 'interactive' is transfered to the firmware via the new > >configuration value FW_CFG_BOOT_INTERACTIVE. > > > >Signed-off-by: Jan Kiszka > > > > This breaks compatibility with existing management tools. Can't we do: > > -boot [order=]drives[,interactive=on|off] > > Certainly, -drive introduces a precedence for this type of format. The 'order=' seems a little overkill - just leave it out entirely, just having: -boot drives,interactive=on|off which is fully back-compatible too. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|