From: Gleb Natapov <gleb@redhat.com>
To: dlaor@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Change RTC time drift IRQ re-injection
Date: Tue, 21 Apr 2009 11:18:11 +0300 [thread overview]
Message-ID: <20090421081811.GA10126@redhat.com> (raw)
In-Reply-To: <49EB2FF2.70806@redhat.com>
On Sun, Apr 19, 2009 at 05:06:42PM +0300, Dor Laor wrote:
> Anthony Liguori wrote:
>> Gleb Natapov wrote:
>>> Currently IRQ are reinjected as soon as they are acknowledged to
>>> the RTC, but Windows sometimes do acknowledgement in a loop with
>>> global interrupt disabled waiting for interrupt to be cleared and
>>> it does not mask RTC vector in PIC/APIC while doing this. In such
>>> situation interrupt injection always fails and RTC interrupt is never
>>> cleared.
>>>
>>> Instead of reinjecting coalesced IRQs on acknowledgement the patch below
>>> reinjects them by accelerating RTC clock a bit. This way RTC interrupt
>>> is not constantly raced after coalesced interrupt.
>>>
>>> Signed-off-by: Gleb Natapov <gleb@redhat.com>
>>> s->cmos_data[RTC_REG_C] = 0x00;
>>> break;
>>> default:
>>> @@ -512,6 +539,7 @@ static void rtc_save_td(QEMUFile *f, void *opaque)
>>> qemu_put_be32(f, s->irq_coalesced);
>>> qemu_put_be32(f, s->period);
>>> + qemu_put_timer(f, s->coalesced_timer);
>>> }
>>> static int rtc_load_td(QEMUFile *f, void *opaque, int version_id)
>>> @@ -523,6 +551,7 @@ static int rtc_load_td(QEMUFile *f, void *opaque,
>>> int version_id)
>>> s->irq_coalesced = qemu_get_be32(f);
>>> s->period = qemu_get_be32(f);
>>> + qemu_get_timer(f, s->coalesced_timer);
>>> return 0;
>>>
>>
>> If you're adding something to the savevm format, you have to increment
>> the version_id and handle older versions correctly.
>>
>>
> Actually, it is not a must to save this boolean, you can assume it is
> set and schedule it for the current time on the load.
>
This is not boolean. This is timer. But you are right, there is no point
is saving it. It can be restarted after migration.
--
Gleb.
prev parent reply other threads:[~2009-04-21 8:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 13:25 [Qemu-devel] [PATCH] Change RTC time drift IRQ re-injection Gleb Natapov
2009-04-18 14:55 ` Anthony Liguori
2009-04-19 14:06 ` Dor Laor
2009-04-21 8:18 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090421081811.GA10126@redhat.com \
--to=gleb@redhat.com \
--cc=dlaor@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).