[Qemu-devel] Switching to git

[Qemu-devel] Switching to git

[Anthony Liguori]

Hi,

It's been mentioned in the past that we're planning a switch from 
subversion to git.  I've setup a git repo on Savannah that is now 
mirroring the svn tree.  I've got a hook setup such that commits 
generate emails.  They're currently being sent to qemu-commits although 
I can redirect to qemu-devel if that's desired.

For users, to get the latest QEMU bits, you would do:

$ git clone git://git.savannah.nongnu.org/qemu.git


For maintainers, Savannah has a getting started page that describes how 
to push commits at http://savannah.gnu.org/maintenance/UsingGit

The git repository is compatible with the repositories on kernel.org and 
repo.or.cz.  All of the tags have been replicated and there is a 
stable_0_10 branch.

I think it would make sense to give people a couple days to verify that 
they can download the git tree properly before switching over, but I'd 
like to tentatively schedule the switching of the git tree to Friday at 
5pm CST unless there are objections.  Until then, please continue 
committing to the SVN tree.

There is also a web interface available at 
http://git.savannah.gnu.org/cgit/qemu.git

-- 
Regards,

Anthony Liguori

Re: [Qemu-devel] Switching to git

[Kevin Wolf]

Anthony Liguori schrieb:
> It's been mentioned in the past that we're planning a switch from 
> subversion to git.  I've setup a git repo on Savannah that is now 
> mirroring the svn tree.  I've got a hook setup such that commits 
> generate emails.  They're currently being sent to qemu-commits although 
> I can redirect to qemu-devel if that's desired.

Personally, I like having the commit messages on the list. But I can 
subscribe to another list as well, I could still filter it into the same 
folder.

> I think it would make sense to give people a couple days to verify that 
> they can download the git tree properly before switching over

I switched already this morning and it seems to work just fine.

Kevin

Re: [Qemu-devel] Switching to git

[Anthony Liguori]

Kevin Wolf wrote:
> Anthony Liguori schrieb:
>> It's been mentioned in the past that we're planning a switch from 
>> subversion to git.  I've setup a git repo on Savannah that is now 
>> mirroring the svn tree.  I've got a hook setup such that commits 
>> generate emails.  They're currently being sent to qemu-commits 
>> although I can redirect to qemu-devel if that's desired.
>
> Personally, I like having the commit messages on the list. But I can 
> subscribe to another list as well, I could still filter it into the 
> same folder.

Once we do the switch and commits have proper author information, I plan 
on adding anyone on the SoB to the CC for these messages to give people 
an automatic indication of when their patch was committed.

My goal is to reduce some of the traffic on qemu-devel.  For those that 
want to read commits, it's easy enough to filter appropriately like 
you've mentioned.

I'm open to suggestion though.

-- 
Regards,

Anthony Liguori

Re: [Qemu-devel] Switching to git

[Gerd Hoffmann]

On 04/22/09 15:22, Anthony Liguori wrote:

> $ git clone git://git.savannah.nongnu.org/qemu.git

Flipped the origin url from kernel.org to savannah, pulled.
git fetched most recent master commit and the stable branch.
Branches look ok.  Had to do a "git fetch -t origin" to get all the tags 
too, without that I got release_0_10_0 only.

> I think it would make sense to give people a couple days to verify that
> they can download the git tree properly before switching over, but I'd
> like to tentatively schedule the switching of the git tree to Friday at
> 5pm CST unless there are objections. Until then, please continue
> committing to the SVN tree.

Go ahead!

cheers,
   Gerd

Re: [Qemu-devel] Switching to git

[Laurent Desnogues]

On Wed, Apr 22, 2009 at 3:22 PM, Anthony Liguori <aliguori@us.ibm.com> wrote:
[...]
> For users, to get the latest QEMU bits, you would do:
>
> $ git clone git://git.savannah.nongnu.org/qemu.git
>
>
> For maintainers, Savannah has a getting started page that describes how to
> push commits at http://savannah.gnu.org/maintenance/UsingGit

And what for people between users and maintainers, for instance those
who propose patches?  Will there be some recommendations on how
to post patches so that it works well?  And don't forget that for some
people just telling "a set of patches is good as long as it can be
bisected" is too short :-)


Laurent

Re: [Qemu-devel] Switching to git

[Anthony Liguori]

Laurent Desnogues wrote:
> On Wed, Apr 22, 2009 at 3:22 PM, Anthony Liguori <aliguori@us.ibm.com> wrote:
> [...]
>   
>> For users, to get the latest QEMU bits, you would do:
>>
>> $ git clone git://git.savannah.nongnu.org/qemu.git
>>
>>
>> For maintainers, Savannah has a getting started page that describes how to
>> push commits at http://savannah.gnu.org/maintenance/UsingGit
>>     
>
> And what for people between users and maintainers, for instance those
> who propose patches?  Will there be some recommendations on how
> to post patches so that it works well?  And don't forget that for some
> people just telling "a set of patches is good as long as it can be
> bisected" is too short :-)
>   

Yup, we'll have a SubmittingPatches that provides the recommended work 
flow.  A really nice property of git is that if you use the various git 
tools to send patches (git-format-patch/git-send-email) then a 
maintainer can grab those automatically via git-am.  It significantly 
reduces the likelihood of loosing information in the process.

> Laurent
>   


-- 
Regards,

Anthony Liguori

Re: [Qemu-devel] Switching to git

[Avi Kivity]

Anthony Liguori wrote:
>
> Yup, we'll have a SubmittingPatches that provides the recommended work 
> flow.  A really nice property of git is that if you use the various 
> git tools to send patches (git-format-patch/git-send-email) then a 
> maintainer can grab those automatically via git-am.  It significantly 
> reduces the likelihood of loosing information in the process.

I'll miss those 'add files missing from previous commit' commits.

-- 
error compiling committee.c: too many arguments to function

Re: [Qemu-devel] Switching to git

[Lennart Sorensen]

On Wed, Apr 22, 2009 at 04:20:44PM +0200, Laurent Desnogues wrote:
> And what for people between users and maintainers, for instance those
> who propose patches?  Will there be some recommendations on how
> to post patches so that it works well?  And don't forget that for some
> people just telling "a set of patches is good as long as it can be
> bisected" is too short :-)

Commits that can be bisected is very appreciated.  I have hit way too
many commits in qemu that cause build failures, segfaults, etc, and just
generally make bisecting a major pain.

The segfaults I can accept as things that happen (although not checking
pointers is kind of sloppy coding, but may run slightly faster when it
is not segfaulting).  Code that doesn't build on the other hand should
never have been checked in.

-- 
Len Sorensen

Re: [Qemu-devel] Switching to git

[Laurent Desnogues]

On Wed, Apr 22, 2009 at 4:38 PM, Lennart Sorensen
<lsorense@csclub.uwaterloo.ca> wrote:
> On Wed, Apr 22, 2009 at 04:20:44PM +0200, Laurent Desnogues wrote:
>> And what for people between users and maintainers, for instance those
>> who propose patches?  Will there be some recommendations on how
>> to post patches so that it works well?  And don't forget that for some
>> people just telling "a set of patches is good as long as it can be
>> bisected" is too short :-)
>
> Commits that can be bisected is very appreciated.  I have hit way too
> many commits in qemu that cause build failures, segfaults, etc, and just
> generally make bisecting a major pain.

I certainly wasn't arguing against bisectability :)

I just wanted to be sure how to achieve it would be described somewhere
to help git newcomers.  I used that as an example of what makes git not
very user friendly, like inventing some new terminology or use new
command names for things that have been used for years.

And before someone jumps on me, I am not arguing against git, I start to
like it.


Laurent

Re: [Qemu-devel] Switching to git

[Lennart Sorensen]

On Wed, Apr 22, 2009 at 04:45:36PM +0200, Laurent Desnogues wrote:
> I certainly wasn't arguing against bisectability :)
> 
> I just wanted to be sure how to achieve it would be described somewhere
> to help git newcomers.  I used that as an example of what makes git not
> very user friendly, like inventing some new terminology or use new
> command names for things that have been used for years.

How does it make git not friendly?  Commiting code that doesn't build
has always caused people pain, it just happens that with git it includes
the pain of loosing use of a major feature of git.

> And before someone jumps on me, I am not arguing against git, I start to
> like it.

I like the regex saerches in commits using git log.  Having git-svn
to grab a svn tree and being able to do all the git tricks on it is
very handy.  A native git tree is much faster to fetch though.

-- 
Len Sorensen

Re: [Qemu-devel] Switching to git

[Johannes Schindelin]

Hi,

On Wed, 22 Apr 2009, Anthony Liguori wrote:

> For users, to get the latest QEMU bits, you would do:
> 
> $ git clone git://git.savannah.nongnu.org/qemu.git

I updated repo.or.cz.

Ciao,
Dscho

Re: [Qemu-devel] Switching to git

[Anthony Liguori]

Johannes Schindelin wrote:
> Hi,
>
> On Wed, 22 Apr 2009, Anthony Liguori wrote:
>
>   
>> For users, to get the latest QEMU bits, you would do:
>>
>> $ git clone git://git.savannah.nongnu.org/qemu.git
>>     
>
> I updated repo.or.cz.
>   

Thanks!

Regards,

Anthony Liguori

> Ciao,
> Dscho
>
>
>   

Re: [Qemu-devel] Switching to git

[Andreas Färber]

Am 22.04.2009 um 16:22 schrieb Anthony Liguori:

> Laurent Desnogues wrote:
>> On Wed, Apr 22, 2009 at 3:22 PM, Anthony Liguori  
>> <aliguori@us.ibm.com> wrote:
>> [...]
>>
>>> For users, to get the latest QEMU bits, you would do:
>>>
>>> $ git clone git://git.savannah.nongnu.org/qemu.git
>>>
>>>
>>> For maintainers, Savannah has a getting started page that  
>>> describes how to
>>> push commits at http://savannah.gnu.org/maintenance/UsingGit
>>>
>>
>> And what for people between users and maintainers, for instance those
>> who propose patches?  Will there be some recommendations on how
>> to post patches so that it works well?  And don't forget that for  
>> some
>> people just telling "a set of patches is good as long as it can be
>> bisected" is too short :-)
>>
>
> Yup, we'll have a SubmittingPatches that provides the recommended  
> work flow.  A really nice property of git is that if you use the  
> various git tools to send patches (git-format-patch/git-send-email)  
> then a maintainer can grab those automatically via git-am.  It  
> significantly reduces the likelihood of loosing information in the  
> process.

Unfortunately tools like git-send-email make me loose information  
instead, by not saving the sent patches in my mail client's or IMAP  
server's Sent Mail folder...

Andreas

Re: [Qemu-devel] Switching to git

[Jamie Lokier]

Andreas Färber wrote:
> Unfortunately tools like git-send-email make me loose information  
> instead, by not saving the sent patches in my mail client's or IMAP  
> server's Sent Mail folder...

This can be done.  Looking briefly at git-send-email's man page, The
--bcc= option (which can be put in a config file) could be used to
send yourself copies on a special address
("user+git-sent@mydomain.com") which you store in your sent folder
using a procmail filter or similar.  That's the most versatile option
- it should work with any mail system which has filtering rules.

Or you could use the --smtp-server= option to send the mail via a
script of your choice which stores a copy.  I wouldn't be surprised if
the script could just run "mutt -H" to send the mail in a usual way.

-- Jamie

Re: [Qemu-devel] Switching to git

[Ryan Harper]

* Andreas F?rber <andreas.faerber@web.de> [2009-04-22 13:03]:
> 
> Am 22.04.2009 um 16:22 schrieb Anthony Liguori:
> 
> >Laurent Desnogues wrote:
> >>On Wed, Apr 22, 2009 at 3:22 PM, Anthony Liguori  
> >><aliguori@us.ibm.com> wrote:
> >>[...]
> >>
> >>>For users, to get the latest QEMU bits, you would do:
> >>>
> >>>$ git clone git://git.savannah.nongnu.org/qemu.git
> >>>
> >>>
> >>>For maintainers, Savannah has a getting started page that  
> >>>describes how to
> >>>push commits at http://savannah.gnu.org/maintenance/UsingGit
> >>>
> >>
> >>And what for people between users and maintainers, for instance those
> >>who propose patches?  Will there be some recommendations on how
> >>to post patches so that it works well?  And don't forget that for  
> >>some
> >>people just telling "a set of patches is good as long as it can be
> >>bisected" is too short :-)
> >>
> >
> >Yup, we'll have a SubmittingPatches that provides the recommended  
> >work flow.  A really nice property of git is that if you use the  
> >various git tools to send patches (git-format-patch/git-send-email)  
> >then a maintainer can grab those automatically via git-am.  It  
> >significantly reduces the likelihood of loosing information in the  
> >process.
> 
> Unfortunately tools like git-send-email make me loose information  
> instead, by not saving the sent patches in my mail client's or IMAP  
> server's Sent Mail folder...

git-send-email sends you a copy of the patches sent.


-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh@us.ibm.com

Re: [Qemu-devel] Switching to git

[Avi Kivity]

Andreas Färber wrote:
>
> Unfortunately tools like git-send-email make me loose information 
> instead, by not saving the sent patches in my mail client's or IMAP 
> server's Sent Mail folder...
>

git config --global sendemail.bcc <me>

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.