From: mtosatti@redhat.com
To: qemu-devel@nongnu.org, aliguori@us.ibm.com
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Subject: [Qemu-devel] [patch 13/14] qemu: handle stop request in main loop
Date: Wed, 22 Apr 2009 16:15:17 -0300 [thread overview]
Message-ID: <20090422192120.833482064@localhost.localdomain> (raw)
In-Reply-To: 20090422191504.975476933@localhost.localdomain
[-- Attachment #1: vmstop-refactor --]
[-- Type: text/plain, Size: 1899 bytes --]
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Index: qemu-iothread-4/vl.c
===================================================================
--- qemu-iothread-4.orig/vl.c
+++ qemu-iothread-4/vl.c
@@ -3483,15 +3483,6 @@ void vm_start(void)
}
}
-void vm_stop(int reason)
-{
- if (vm_running) {
- cpu_disable_ticks();
- vm_running = 0;
- vm_state_notify(0, reason);
- }
-}
-
/* reset/shutdown handler */
typedef struct QEMUResetEntry {
@@ -3505,6 +3496,7 @@ static int reset_requested;
static int shutdown_requested;
static int powerdown_requested;
static int debug_requested;
+static int vmstop_requested;
int qemu_shutdown_requested(void)
{
@@ -3534,6 +3526,22 @@ static int qemu_debug_requested(void)
return r;
}
+static int qemu_vmstop_requested(void)
+{
+ int r = vmstop_requested;
+ vmstop_requested = 0;
+ return r;
+}
+
+static void do_vm_stop(int reason)
+{
+ if (vm_running) {
+ cpu_disable_ticks();
+ vm_running = 0;
+ vm_state_notify(0, reason);
+ }
+}
+
void qemu_register_reset(QEMUResetHandler *func, void *opaque)
{
QEMUResetEntry **pre, *re;
@@ -3697,6 +3705,11 @@ static void qemu_init_main_loop(void)
#define qemu_mutex_lock_iothread() do { } while (0)
#define qemu_mutex_unlock_iothread() do { } while (0)
+void vm_stop(int reason)
+{
+ do_vm_stop(reason);
+}
+
#ifdef _WIN32
static void host_main_loop_wait(int *timeout)
{
@@ -3994,8 +4007,9 @@ static int vm_can_run(void)
static void main_loop(void)
{
- for (;;) {
+ int r;
+ for (;;) {
do {
#ifdef CONFIG_PROFILER
int64_t ti;
@@ -4023,6 +4037,8 @@ static void main_loop(void)
qemu_system_reset();
if (qemu_powerdown_requested())
qemu_system_powerdown();
+ if ((r = qemu_vmstop_requested()))
+ vm_stop(r);
}
}
--
next prev parent reply other threads:[~2009-04-22 19:34 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090407195126.467365249@localhost.localdomain>
[not found] ` <20090407195442.646407971@localhost.localdomain>
2009-04-16 20:53 ` [Qemu-devel] Re: [patch 01/11] qemu: create helper for event notification Anthony Liguori
2009-04-16 20:58 ` Marcelo Tosatti
2009-04-17 17:21 ` Anthony Liguori
[not found] ` <20090407195442.764405844@localhost.localdomain>
2009-04-17 13:53 ` [Qemu-devel] Re: [patch 02/11] qemu: mutex/thread/cond wrappers Anthony Liguori
[not found] ` <20090407195443.004166674@localhost.localdomain>
2009-04-17 13:57 ` [Qemu-devel] Re: [patch 04/11] qemu: introduce main_loop_break Anthony Liguori
[not found] ` <20090407195443.121795529@localhost.localdomain>
2009-04-17 14:05 ` [Qemu-devel] Re: [patch 05/11] qemu: separate thread for io Anthony Liguori
2009-04-18 20:45 ` Marcelo Tosatti
[not found] ` <20090407195443.716079176@localhost.localdomain>
2009-04-17 14:07 ` [Qemu-devel] Re: [patch 10/11] qemu: make iothread selectable at compile time Anthony Liguori
[not found] ` <20090407195443.832269134@localhost.localdomain>
2009-04-17 14:09 ` [Qemu-devel] Re: [patch 11/11] qemu: basic kvm iothread support Anthony Liguori
2009-04-22 19:15 ` [Qemu-devel] [patch 00/14] qemu: introduce iothread (v4) mtosatti
2009-04-22 19:15 ` [Qemu-devel] [patch 01/14] qemu: create helper for event notification mtosatti
2009-04-22 19:15 ` [Qemu-devel] [patch 02/14] qemu: mutex/thread/cond wrappers and configure tweaks mtosatti
2009-04-22 20:33 ` [Qemu-devel] " Anthony Liguori
2009-04-23 11:15 ` [Qemu-devel] svn trunk currently borked Martin Mohring
2009-04-23 11:58 ` Laurent Desnogues
2009-04-23 13:17 ` Anthony Liguori
2009-04-23 13:21 ` Martin Mohring
2009-04-22 19:15 ` [Qemu-devel] [patch 03/14] qemu: per-arch cpu_has_work mtosatti
2009-04-22 19:15 ` [Qemu-devel] [patch 04/14] qemu: explictly rearm alarm timer on main_loop_wait mtosatti
2009-04-22 19:15 ` [Qemu-devel] [patch 05/14] qemu: factor out special event notification mtosatti
2009-04-22 20:58 ` Anthony Liguori
2009-04-22 19:15 ` [Qemu-devel] [patch 06/14] qemu: refactor main_loop mtosatti
2009-04-22 19:15 ` [Qemu-devel] [patch 07/14] qemu: introduce qemu_init_vcpu mtosatti
2009-04-22 19:15 ` [Qemu-devel] [patch 08/14] qemu: introduce qemu_cpu_kick mtosatti
2009-04-22 19:15 ` [Qemu-devel] [patch 09/14] qemu: introduce qemu_init_main_loop mtosatti
2009-04-22 19:15 ` [Qemu-devel] [patch 10/14] qemu: introduce lock/unlock_iothread mtosatti
2009-04-22 19:15 ` [Qemu-devel] [patch 11/14] qemu: use debug_requested global instead of cpu_exec return mtosatti
2009-04-22 19:15 ` [Qemu-devel] [patch 12/14] qemu: refactor tcg cpu execution loop mtosatti
2009-04-22 19:15 ` mtosatti [this message]
2009-04-22 19:15 ` [Qemu-devel] [patch 14/14] qemu: introduce iothread mtosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090422192120.833482064@localhost.localdomain \
--to=mtosatti@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).