From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lwj3O-00077a-K1
	for qemu-devel@nongnu.org; Wed, 22 Apr 2009 16:28:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lwj3I-00074l-IP
	for qemu-devel@nongnu.org; Wed, 22 Apr 2009 16:28:21 -0400
Received: from [199.232.76.173] (port=49009 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lwj3H-00074a-La
	for qemu-devel@nongnu.org; Wed, 22 Apr 2009 16:28:15 -0400
Received: from mx2.redhat.com ([66.187.237.31]:33372)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1Lwj3H-00013r-6g
	for qemu-devel@nongnu.org; Wed, 22 Apr 2009 16:28:15 -0400
Date: Wed, 22 Apr 2009 23:28:11 +0300
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] Change RTC time drift IRQ re-injection
Message-ID: <20090422202811.GC29292@redhat.com>
References: <20090421082100.GB10126@redhat.com> <49EF7CD2.5080001@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <49EF7CD2.5080001@us.ibm.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org

On Wed, Apr 22, 2009 at 03:23:46PM -0500, Anthony Liguori wrote:
> Gleb Natapov wrote:
>> Currently IRQ are reinjected as soon as they are acknowledged to
>> the RTC, but Windows sometimes do acknowledgement in a loop with
>> global interrupt disabled waiting for interrupt to be cleared and
>> it does not mask RTC vector in PIC/APIC while doing this. In such
>> situation interrupt injection always fails and RTC interrupt is never
>> cleared.
>>
>> Instead of reinjecting coalesced IRQs on acknowledgement the patch below
>> reinjects them by accelerating RTC clock a bit. This way RTC interrupt
>> is not constantly raced after coalesced interrupt.
>>
>> Signed-off-by: Gleb Natapov <gleb@redhat.com>
>>   
>
> Applied, but...
>
>> @@ -536,6 +563,7 @@ static int rtc_load_td(QEMUFile *f, void *opaque, int version_id)
>>       s->irq_coalesced = qemu_get_be32(f);
>>      s->period = qemu_get_be32(f);
>> +    rtc_coalesced_timer_update(s)
>>      return 0;
>>  }
>>  #endif
> You were missing a ';'.  I added it.
>
Wow :(. I compiled it and even tested. Honestly! Something on the
internet eats semicolons.


--
			Gleb.