From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lx54m-0007Qj-88 for qemu-devel@nongnu.org; Thu, 23 Apr 2009 15:59:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lx54h-0007Mx-0j for qemu-devel@nongnu.org; Thu, 23 Apr 2009 15:59:15 -0400 Received: from [199.232.76.173] (port=35440 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lx54g-0007Mp-MS for qemu-devel@nongnu.org; Thu, 23 Apr 2009 15:59:10 -0400 Received: from mx20.gnu.org ([199.232.41.8]:43075) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lx54g-0006OJ-70 for qemu-devel@nongnu.org; Thu, 23 Apr 2009 15:59:10 -0400 Received: from caffeine.csclub.uwaterloo.ca ([129.97.134.17]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lx54f-0001uq-Jt for qemu-devel@nongnu.org; Thu, 23 Apr 2009 15:59:09 -0400 Date: Thu, 23 Apr 2009 15:59:02 -0400 Subject: Re: [Qemu-devel] [7234] Use a more natural order Message-ID: <20090423195902.GN3795@csclub.uwaterloo.ca> References: <20090423185308.GH3795@csclub.uwaterloo.ca> <20090423191040.GI3795@csclub.uwaterloo.ca> <5d6222a80904231215p62c6594asc50230b252e892aa@mail.gmail.com> <49F0C826.4060503@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49F0C826.4060503@codemonkey.ws> From: lsorense@csclub.uwaterloo.ca (Lennart Sorensen) List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Blue Swirl , Glauber Costa , qemu-devel@nongnu.org On Thu, Apr 23, 2009 at 02:57:26PM -0500, Anthony Liguori wrote: > In all fairness, I usually only do that when it's something I think > people would comment on. I probably would do a fix up like this by just > committing. > > People miss things, it happens. No process is going to prevent it > happening 100% of the time. If you can't bother to compile test it, you shouldn't be commiting. Your time isn't worth that much more than everyone else that gets inconvinienced by the sloppy commit. That's a procedure that can certainly help. -- Len Sorensen