From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LxQc6-0002xx-17 for qemu-devel@nongnu.org; Fri, 24 Apr 2009 14:59:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LxQc1-0002xV-CA for qemu-devel@nongnu.org; Fri, 24 Apr 2009 14:59:05 -0400 Received: from [199.232.76.173] (port=38429 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LxQc1-0002xS-6T for qemu-devel@nongnu.org; Fri, 24 Apr 2009 14:59:01 -0400 Received: from mx20.gnu.org ([199.232.41.8]:1969) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LxQc0-0002ut-Si for qemu-devel@nongnu.org; Fri, 24 Apr 2009 14:59:00 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LxQby-0000JG-SH for qemu-devel@nongnu.org; Fri, 24 Apr 2009 14:58:59 -0400 Date: Fri, 24 Apr 2009 11:58:57 -0700 From: Nathan Froyd Subject: Re: [Qemu-devel] [7234] Use a more natural order Message-ID: <20090424185857.GA22588@codesourcery.com> References: <20090423185308.GH3795@csclub.uwaterloo.ca> <20090423191040.GI3795@csclub.uwaterloo.ca> <20090423194447.GK3795@csclub.uwaterloo.ca> <20090423224625.GP13326@shareable.org> <20090424180706.GR3795@csclub.uwaterloo.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090424180706.GR3795@csclub.uwaterloo.ca> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lennart Sorensen Cc: Blue Swirl , qemu-devel@nongnu.org On Fri, Apr 24, 2009 at 02:07:06PM -0400, Lennart Sorensen wrote: > On Thu, Apr 23, 2009 at 11:46:25PM +0100, Jamie Lokier wrote: > > Sure, it was ok practice back in the days when compilers would let you > > write "if (x = 0)", but those days are long gone. Now all compilers > > warn, and you can ask them to make it an error. A compiler check is > > much safer than depending on writing style, especially a weird one > > that's inconsistent with other writing in the same code, and > > inconsistent with English thinking. > > I highly doubt all compilers warn. Current gcc versions do, but not > everyone uses current gcc. Documentation indicates that the relevant warning (-Wparatheses) has been supported since at least 2.95.3 (released early 2001); I imagine it has been supported since the corresponding major release of 2.95.0 (released mid-1999). -Nathan