From: Christoph Hellwig <hch@lst.de>
To: Avi Kivity <avi@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
dlaor@redhat.com, Christoph Hellwig <hch@lst.de>,
gleb@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qcow2 corruption: Fix alloc_cluster_link_l2
Date: Sun, 26 Apr 2009 16:41:18 +0200 [thread overview]
Message-ID: <20090426144118.GA25792@lst.de> (raw)
In-Reply-To: <49F46C2B.9060705@redhat.com>
On Sun, Apr 26, 2009 at 05:14:03PM +0300, Avi Kivity wrote:
> Christoph Hellwig wrote:
> >Maybe it's time to make use of sparse's endianess annotations in qcow2
> >to prevent further problems like this one
>
> I'd much prefer strong type checking at compile time:
sparse has strong typechecking at compiletime for the __bitwise types,
although you need the special sparse compiler to parse the annotations
:)
And the big advantage is that qemu already has the infrastructure for
it, while for your new structs you'd need various new helpers, including
for comparisms of disk endian types, etc.
prev parent reply other threads:[~2009-04-26 14:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-15 9:52 [Qemu-devel] [PATCH] qcow2 corruption: Fix alloc_cluster_link_l2 Kevin Wolf
2009-04-15 10:05 ` [Qemu-devel] " Gleb Natapov
2009-04-15 15:28 ` Consul
2009-04-16 6:30 ` Marc Bevand
2009-04-17 20:44 ` Anthony Liguori
2009-04-26 13:24 ` [Qemu-devel] " Christoph Hellwig
2009-04-26 14:14 ` Avi Kivity
2009-04-26 14:41 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090426144118.GA25792@lst.de \
--to=hch@lst.de \
--cc=avi@redhat.com \
--cc=dlaor@redhat.com \
--cc=gleb@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).