qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Blue Swirl <blauwirbel@gmail.com>,
	qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH] Move block format drivers to new directory 'bdrv'
Date: Sun, 26 Apr 2009 19:56:30 +0200	[thread overview]
Message-ID: <20090426175630.GA2106@lst.de> (raw)
In-Reply-To: <49F49D6C.7080100@codemonkey.ws>

On Sun, Apr 26, 2009 at 12:44:12PM -0500, Anthony Liguori wrote:
> >|-- audio
> >|-- block
> >|-- bluetooth
> >|-- crypto
> >|-- net
> >|   `-- slirp
> >|-- parport
> >|-- scsi
> >|-- serial
> >|-- usb
> >`-- video
> >  
> 
> There's an awful lot of code refactoring needed before such a layout 
> would make sense.  In general, I think until there are at least 3 files 
> in the form something-foo.c, it doesn't make sense to convert to 
> something/foo.c

I agree.  Useful subdirectories I can see currently are:

 - usb
 - net
 - bluetooth
 - block
 - vnc
 
after looking at the code again I would also include the various scsi
files in the block directoty, they are pretty closely related and will
get even more interwinded with things like SG_IO passthrough for virtio.

  reply	other threads:[~2009-04-26 17:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-26 15:19 [Qemu-devel] [PATCH] Move block format drivers to new directory 'bdrv' Avi Kivity
2009-04-26 15:29 ` Christoph Hellwig
2009-04-26 15:55   ` Avi Kivity
2009-04-26 16:18     ` Blue Swirl
2009-04-26 16:20       ` Avi Kivity
2009-04-26 16:40         ` Blue Swirl
2009-04-26 17:04           ` Avi Kivity
2009-04-26 17:44           ` Anthony Liguori
2009-04-26 17:56             ` Christoph Hellwig [this message]
2009-04-26 18:06               ` Avi Kivity
2009-04-26 17:41         ` Anthony Liguori
2009-04-26 18:10           ` Blue Swirl
2009-04-26 21:26             ` Stefan Weil
2009-04-27 12:14             ` Kevin Wolf
2009-04-27 13:52               ` Jamie Lokier
2009-04-27 14:37                 ` M. Warner Losh
2009-04-27 12:08 ` Kevin Wolf
2009-04-27 12:10   ` Avi Kivity
2009-04-27 12:17     ` Kevin Wolf
2009-05-02 10:34   ` Stuart Brady

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090426175630.GA2106@lst.de \
    --to=hch@lst.de \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).