From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ly8an-0003tz-64
	for qemu-devel@nongnu.org; Sun, 26 Apr 2009 13:56:41 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Ly8ah-0003q0-Mb
	for qemu-devel@nongnu.org; Sun, 26 Apr 2009 13:56:39 -0400
Received: from [199.232.76.173] (port=38247 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ly8ah-0003px-3Y
	for qemu-devel@nongnu.org; Sun, 26 Apr 2009 13:56:35 -0400
Received: from verein.lst.de ([213.95.11.210]:40537)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1Ly8ag-0002j1-Hp
	for qemu-devel@nongnu.org; Sun, 26 Apr 2009 13:56:34 -0400
Date: Sun, 26 Apr 2009 19:56:30 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH] Move block format drivers to new directory
	'bdrv'
Message-ID: <20090426175630.GA2106@lst.de>
References: <1240759177-27527-1-git-send-email-avi@redhat.com>
	<20090426152943.GA27812@lst.de> <49F483E8.4050005@redhat.com>
	<f43fc5580904260918n142000e5u1bdf53b6c7b85e32@mail.gmail.com>
	<49F489B7.5000705@redhat.com>
	<f43fc5580904260940t430d4ffh77804217e4e69c2e@mail.gmail.com>
	<49F49D6C.7080100@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <49F49D6C.7080100@codemonkey.ws>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>, Christoph Hellwig <hch@lst.de>

On Sun, Apr 26, 2009 at 12:44:12PM -0500, Anthony Liguori wrote:
> >|-- audio
> >|-- block
> >|-- bluetooth
> >|-- crypto
> >|-- net
> >|   `-- slirp
> >|-- parport
> >|-- scsi
> >|-- serial
> >|-- usb
> >`-- video
> >  
> 
> There's an awful lot of code refactoring needed before such a layout 
> would make sense.  In general, I think until there are at least 3 files 
> in the form something-foo.c, it doesn't make sense to convert to 
> something/foo.c

I agree.  Useful subdirectories I can see currently are:

 - usb
 - net
 - bluetooth
 - block
 - vnc
 
after looking at the code again I would also include the various scsi
files in the block directoty, they are pretty closely related and will
get even more interwinded with things like SG_IO passthrough for virtio.