From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LyUWX-0008Rq-EE for qemu-devel@nongnu.org; Mon, 27 Apr 2009 13:21:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LyUWS-0008Og-UA for qemu-devel@nongnu.org; Mon, 27 Apr 2009 13:21:45 -0400 Received: from [199.232.76.173] (port=59148 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LyUWS-0008OX-HM for qemu-devel@nongnu.org; Mon, 27 Apr 2009 13:21:40 -0400 Received: from mx20.gnu.org ([199.232.41.8]:31974) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LyUWS-0006Pp-81 for qemu-devel@nongnu.org; Mon, 27 Apr 2009 13:21:40 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LyUWQ-0006LW-3q for qemu-devel@nongnu.org; Mon, 27 Apr 2009 13:21:38 -0400 Date: Mon, 27 Apr 2009 10:21:34 -0700 From: Nathan Froyd Subject: Re: [Qemu-devel] [PATCH] linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt Message-ID: <20090427172134.GA23911@codesourcery.com> References: <1240695019.21332.1.camel@coalu.atr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1240695019.21332.1.camel@coalu.atr> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Sat, Apr 25, 2009 at 11:30:19PM +0200, Lionel Landwerlin wrote: > linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt Should these be TARGET_IP_* instead, or are they like the FUTEX_* constants and the same on every platform? If the latter, at the very least there should be explanatory comments somewhere--just making them TARGET_IP_* would be even better, IMHO. -Nathan