From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lym73-0006W4-OG
	for qemu-devel@nongnu.org; Tue, 28 Apr 2009 08:08:37 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lym6y-0006SL-BP
	for qemu-devel@nongnu.org; Tue, 28 Apr 2009 08:08:36 -0400
Received: from [199.232.76.173] (port=57779 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lym6x-0006S0-VE
	for qemu-devel@nongnu.org; Tue, 28 Apr 2009 08:08:32 -0400
Received: from mx20.gnu.org ([199.232.41.8]:24061)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1Lym6x-0007if-KH
	for qemu-devel@nongnu.org; Tue, 28 Apr 2009 08:08:31 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1Lym6v-0008UE-PX
	for qemu-devel@nongnu.org; Tue, 28 Apr 2009 08:08:30 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup()
Date: Tue, 28 Apr 2009 13:08:25 +0100
References: <1239812969-8320-2-git-send-email-markmc@redhat.com>
	<20090416010725.GA24264@amt.cnet> <1239893397.6860.190.camel@blaa>
In-Reply-To: <1239893397.6860.190.camel@blaa>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200904281308.26203.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, Mark McLoughlin <markmc@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, Markus Armbruster <armbru@redhat.com>

On Thursday 16 April 2009, Mark McLoughlin wrote:
> However, the way I see it is that the VLANClientState should "own" the
> PCIDevice, not the other way around - e.g. you want to free the device,
> you should do qemu_del_vlan_client(), rather than
> pci_device_unregister().

I disagree. This makes it impossible to have multiport devices.
The controlling entity should be the device, not the vlan interface.

This is related to some of the issues I've raised with the machine config 
patches. IMO it's important to consider how this kind of internat interaction 
should actually work, rather than blindly implementing whatever we currently 
expose to the user.

Paul