From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lyr41-0001ke-VZ for qemu-devel@nongnu.org; Tue, 28 Apr 2009 13:25:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lyr3x-0001ic-J2 for qemu-devel@nongnu.org; Tue, 28 Apr 2009 13:25:49 -0400 Received: from [199.232.76.173] (port=54995 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lyr3x-0001iZ-DK for qemu-devel@nongnu.org; Tue, 28 Apr 2009 13:25:45 -0400 Received: from mx20.gnu.org ([199.232.41.8]:43154) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lyr3x-0002CP-7r for qemu-devel@nongnu.org; Tue, 28 Apr 2009 13:25:45 -0400 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lyr3w-0000Ld-Gc for qemu-devel@nongnu.org; Tue, 28 Apr 2009 13:25:44 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH, RFC] Smarter compilation for target devices Date: Tue, 28 Apr 2009 18:25:40 +0100 References: <200904281432.42291.paul@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904281825.41235.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl > > former. Duplicating this logic is both cpu.h and configure is also > > asking for trouble. At minimum the build should fail if they disagree. > > Which logic? The logic that determines TARGET_PHYS_ADDR_BITS. By my reading TARGET_PHYS_ADDR_BITS is alway 64 on 64-bit hosts, so there's no reason to build separate libraries there. On a related note, the current big/little endian handling is fairly findamentally broken. It kinda works for the current set of targets. However for other targets (e.g. big-endian arm, in particular ixp4xx) it doesn't work because the endianess of the device depends which bus it's connected to. We really need to push the byte swapping down to the softmmu/iotlb code. Paul