From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LzE5Z-0005mt-3s
	for qemu-devel@nongnu.org; Wed, 29 Apr 2009 14:00:57 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LzE5W-0005jK-AB
	for qemu-devel@nongnu.org; Wed, 29 Apr 2009 14:00:55 -0400
Received: from [199.232.76.173] (port=40175 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LzE5V-0005j6-Tr
	for qemu-devel@nongnu.org; Wed, 29 Apr 2009 14:00:53 -0400
Received: from naru.obs2.net ([84.20.150.76]:44329)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <nchip@kos.to>) id 1LzE5V-0005PH-CW
	for qemu-devel@nongnu.org; Wed, 29 Apr 2009 14:00:53 -0400
Date: Wed, 29 Apr 2009 21:00:48 +0300
From: Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [Qemu-devel] [PATCH] linux-user: Added
	IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt
Message-ID: <20090429180048.GA19011@kos.to>
References: <1240695019.21332.1.camel@coalu.atr>
	<20090427172134.GA23911@codesourcery.com>
	<1240855506.29022.1.camel@coalu.atr>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1240855506.29022.1.camel@coalu.atr>
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lionel Landwerlin <lionel.landwerlin@openwide.fr>
Cc: qemu-devel@nongnu.org, Nathan Froyd <froydnj@codesourcery.com>

On Mon, Apr 27, 2009 at 08:05:06PM +0200, Lionel Landwerlin wrote:
> Le lundi 27 avril 2009 =C3=A0 10:21 -0700, Nathan Froyd a =C3=A9crit :
> > On Sat, Apr 25, 2009 at 11:30:19PM +0200, Lionel Landwerlin wrote:
> > > linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to set=
sockopt

> > Should these be TARGET_IP_* instead, or are they like the FUTEX_*
> > constants and the same on every platform?  If the latter, at the very
> > least there should be explanatory comments somewhere--just making the=
m
> > TARGET_IP_* would be even better, IMHO.

> I'm agree too, I just did the way it was before...

These are defined in include/linux/in.h so they should be same on all arc=
hs?

Cheers,
Riku