From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LzGVh-0005bM-1p
	for qemu-devel@nongnu.org; Wed, 29 Apr 2009 16:36:05 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LzGVe-0005bA-Fz
	for qemu-devel@nongnu.org; Wed, 29 Apr 2009 16:36:03 -0400
Received: from [199.232.76.173] (port=37120 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LzGVe-0005b7-Cv
	for qemu-devel@nongnu.org; Wed, 29 Apr 2009 16:36:02 -0400
Received: from mail2.shareable.org ([80.68.89.115]:36113)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <jamie@shareable.org>) id 1LzGVe-0003RL-0u
	for qemu-devel@nongnu.org; Wed, 29 Apr 2009 16:36:02 -0400
Date: Wed, 29 Apr 2009 21:35:52 +0100
From: Jamie Lokier <jamie@shareable.org>
Subject: Re: [Qemu-devel] [PATCH] linux-user: Added
	IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt
Message-ID: <20090429203552.GB20993@shareable.org>
References: <1240695019.21332.1.camel@coalu.atr>
	<20090427172134.GA23911@codesourcery.com>
	<1240855506.29022.1.camel@coalu.atr>
	<20090429180048.GA19011@kos.to>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20090429180048.GA19011@kos.to>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Riku Voipio <riku.voipio@iki.fi>
Cc: Lionel Landwerlin <lionel.landwerlin@openwide.fr>, Nathan Froyd <froydnj@codesourcery.com>, qemu-devel@nongnu.org

Riku Voipio wrote:
> On Mon, Apr 27, 2009 at 08:05:06PM +0200, Lionel Landwerlin wrote:
> > Le lundi 27 avril 2009 à 10:21 -0700, Nathan Froyd a écrit :
> > > On Sat, Apr 25, 2009 at 11:30:19PM +0200, Lionel Landwerlin wrote:
> > > > linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt
> 
> > > Should these be TARGET_IP_* instead, or are they like the FUTEX_*
> > > constants and the same on every platform?  If the latter, at the very
> > > least there should be explanatory comments somewhere--just making them
> > > TARGET_IP_* would be even better, IMHO.
> 
> > I'm agree too, I just did the way it was before...
> 
> These are defined in include/linux/in.h so they should be same on all archs?

But what if you're compiling for a non-Linux host?

IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP are standard BSD sockets options,
found everywhere, even on Windows I think.

-- Jamie