From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LzYnx-0002sx-Df
	for qemu-devel@nongnu.org; Thu, 30 Apr 2009 12:08:09 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LzYns-0002lx-KU
	for qemu-devel@nongnu.org; Thu, 30 Apr 2009 12:08:08 -0400
Received: from [199.232.76.173] (port=60112 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LzYns-0002ll-AK
	for qemu-devel@nongnu.org; Thu, 30 Apr 2009 12:08:04 -0400
Received: from mx20.gnu.org ([199.232.41.8]:6540)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1LzYnr-0003te-Ue
	for qemu-devel@nongnu.org; Thu, 30 Apr 2009 12:08:04 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1LzYnr-00032C-Eq
	for qemu-devel@nongnu.org; Thu, 30 Apr 2009 12:08:03 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 1/16] ARM Add ARM 920T identifiers
Date: Thu, 30 Apr 2009 17:08:01 +0100
References: <20090423171503.GC4629@derik> <20090423174513.GD4629@derik>
In-Reply-To: <20090423174513.GD4629@derik>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200904301708.01385.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Vincent Sanders <vince@kyllikki.org>

>      env->cp15.c0_cpuid = id;
>      switch (id) {
> +    case ARM_CPUID_ARM920T:
> +       break;

This is woefully incomplete. At minimum it needs a comment describing how this 
is a lie.

Paul