From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Nathan Froyd <froydnj@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] [RFC] cleanup cpu-exec.c: consolidate handle_cpu_signal
Date: Thu, 30 Apr 2009 17:10:38 +0100 [thread overview]
Message-ID: <200904301710.38740.paul@codesourcery.com> (raw)
In-Reply-To: <1240364008-7065-1-git-send-email-froydnj@codesourcery.com>
> I don't understand what the "activate soft MMU for this block" is trying
> to do. (Especially since handle_cpu_signal and company are under
> !defined(CONFIG_SOFTMMU)...) Even though it appears that if
> cpu_*_handle_mmu_fault ever returns a value > 0, that value is always
> one and therefore that block is superfluous, I've left that cleanup for
> a later time. Likewise for why x86 has a different EXCEPTION_ACTION
> than everyone else.
This is most likely a remnant of the long-deceased qemu-fast, which used mmap
tricks to avoid MMU emulation in system mode.
Paul
next prev parent reply other threads:[~2009-04-30 16:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 1:33 [Qemu-devel] [PATCH] [RFC] cleanup cpu-exec.c: consolidate handle_cpu_signal Nathan Froyd
2009-04-30 16:10 ` Paul Brook [this message]
2009-04-30 16:34 ` Avi Kivity
2009-04-30 17:07 ` Paul Brook
2009-04-30 17:56 ` Avi Kivity
2009-04-30 18:52 ` Blue Swirl
2009-04-30 18:57 ` Avi Kivity
2009-04-30 19:05 ` Blue Swirl
2009-04-30 20:52 ` Laurent Desnogues
2009-08-01 20:42 ` Filip Navara
2009-08-03 15:59 ` Nathan Froyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904301710.38740.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=froydnj@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).