From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LzqyY-0008QC-JK
	for qemu-devel@nongnu.org; Fri, 01 May 2009 07:32:19 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LzqyS-0008PL-SN
	for qemu-devel@nongnu.org; Fri, 01 May 2009 07:32:16 -0400
Received: from [199.232.76.173] (port=34557 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LzqyS-0008P3-Jo
	for qemu-devel@nongnu.org; Fri, 01 May 2009 07:32:12 -0400
Received: from mx2.redhat.com ([66.187.237.31]:45675)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rjones@redhat.com>) id 1LzqyS-00067l-1c
	for qemu-devel@nongnu.org; Fri, 01 May 2009 07:32:12 -0400
Date: Fri, 1 May 2009 12:32:04 +0100
From: "Richard W.M. Jones" <rjones@redhat.com>
Subject: Re: [Qemu-devel] PATCH: enabling TCP keepalives - v3
Message-ID: <20090501113204.GA10763@amd.home.annexia.org>
References: <49F9FEBA.6050901@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <49F9FEBA.6050901@gmail.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Ahern <dsahern@gmail.com>
Cc: qemu-devel@nongnu.org

On Thu, Apr 30, 2009 at 01:40:42PM -0600, David Ahern wrote:
> Did not see a response to the last version.
> 
> This patch enables TCP keepalives on VNC connections and TCP-based char
> devices.
> 
> Default parameters have keep alive probes sent after 60-seconds of idle
> time. Probes are sent every 12 seconds with the connection resetting
> after 5 failed probes (ie., connection is closed if no response received
> in 60-seconds).

IMHO this should be optional, and firmly default to _OFF_.  Brief
network outages shouldn't result in connections failing all over the
place.  In addition, does this negatively impact migration?

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw