From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>, David Ahern <dsahern@gmail.com>
Subject: Re: [Qemu-devel] PATCH: enabling TCP keepalives - v3
Date: Fri, 1 May 2009 16:16:12 +0100 [thread overview]
Message-ID: <200905011616.13164.paul@codesourcery.com> (raw)
In-Reply-To: <49FB0C57.9020501@us.ibm.com>
On Friday 01 May 2009, Anthony Liguori wrote:
> David Ahern wrote:
> > Missed that. Forgot to add net.h to vnc.c.
> >
> > Before I re-send a patch, what's the feeling regarding enabling this all
> > the time versus a command line option to control it?
> >
> > david
>
> I'm on the fence. It's not something I think is extremely common and it
> seems like we're going to great lengths to fix up one persons broken
> configuration.
I'm wary of enabling this by default. As someone else mentioned, having your
TCP console connections spontaneously combust after 60 seconds can be
somewhat surprising.
An option seems reasonable enough. We already have this for nodelay.
Paul
next prev parent reply other threads:[~2009-05-01 15:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-30 19:40 [Qemu-devel] PATCH: enabling TCP keepalives - v3 David Ahern
2009-05-01 11:32 ` Richard W.M. Jones
2009-05-01 12:23 ` Jamie Lokier
2009-05-01 12:49 ` David Ahern
2009-05-01 15:23 ` Daniel P. Berrange
2009-05-01 15:47 ` David Ahern
2009-05-01 17:21 ` Richard W.M. Jones
2009-05-05 1:31 ` Jamie Lokier
2009-05-05 2:59 ` David Ahern
2009-05-01 15:52 ` Avi Kivity
2009-05-01 16:11 ` John Haxby
2009-05-05 1:35 ` Jamie Lokier
2009-05-01 14:43 ` Anthony Liguori
2009-05-01 14:47 ` David Ahern
2009-05-01 14:51 ` Anthony Liguori
2009-05-01 15:16 ` Paul Brook [this message]
2009-05-01 15:57 ` Anthony Liguori
2009-05-01 16:04 ` Paul Brook
2009-05-01 16:11 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905011616.13164.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=aliguori@us.ibm.com \
--cc=dsahern@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).