From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LzuTN-00032A-I9
	for qemu-devel@nongnu.org; Fri, 01 May 2009 11:16:21 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LzuTJ-000313-2s
	for qemu-devel@nongnu.org; Fri, 01 May 2009 11:16:21 -0400
Received: from [199.232.76.173] (port=33497 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LzuTI-00030z-V9
	for qemu-devel@nongnu.org; Fri, 01 May 2009 11:16:17 -0400
Received: from mx20.gnu.org ([199.232.41.8]:12031)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1LzuTI-0007WB-PL
	for qemu-devel@nongnu.org; Fri, 01 May 2009 11:16:16 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1LzuTH-0003aO-QV
	for qemu-devel@nongnu.org; Fri, 01 May 2009 11:16:16 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] PATCH: enabling TCP keepalives - v3
Date: Fri, 1 May 2009 16:16:12 +0100
References: <49F9FEBA.6050901@gmail.com> <49FB0B67.5070305@gmail.com>
	<49FB0C57.9020501@us.ibm.com>
In-Reply-To: <49FB0C57.9020501@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="windows-1252"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200905011616.13164.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>, David Ahern <dsahern@gmail.com>

On Friday 01 May 2009, Anthony Liguori wrote:
> David Ahern wrote:
> > Missed that. Forgot to add net.h to vnc.c.
> >
> > Before I re-send a patch, what's the feeling regarding enabling this all
> > the time versus a command line option to control it?
> >
> > david
>
> I'm on the fence.  It's not something I think is extremely common and it
> seems like we're going to great lengths to fix up one persons broken
> configuration.

I'm wary of enabling this by default. As someone else mentioned, having your 
TCP console connections spontaneously combust after 60 seconds can be 
somewhat surprising.

An option seems reasonable enough. We already have this for nodelay.

Paul