From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M00ev-0003VK-0F
	for qemu-devel@nongnu.org; Fri, 01 May 2009 17:52:41 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M00eq-0003Uk-FP
	for qemu-devel@nongnu.org; Fri, 01 May 2009 17:52:40 -0400
Received: from [199.232.76.173] (port=44797 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M00eq-0003UU-7b
	for qemu-devel@nongnu.org; Fri, 01 May 2009 17:52:36 -0400
Received: from verein.lst.de ([213.95.11.210]:57151)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1M00ep-0005lJ-Ng
	for qemu-devel@nongnu.org; Fri, 01 May 2009 17:52:36 -0400
Date: Fri, 1 May 2009 23:52:26 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] PATCH: add missing (dummy) raw_aio_ioctl() for
	FreeBSD case
Message-ID: <20090501215226.GA32559@lst.de>
References: <20090501193030.GA44740@triton.kn-bremen.de>
	<49FB55ED.7050005@codemonkey.ws>
	<20090501.141852.-1646077921.imp@bsdimp.com>
	<20090501211918.GA48123@triton.kn-bremen.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090501211918.GA48123@triton.kn-bremen.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juergen Lock <nox@jelal.kn-bremen.de>
Cc: qemu-devel@nongnu.org

On Fri, May 01, 2009 at 11:19:18PM +0200, Juergen Lock wrote:
> Oh, we are using aio afaict, at least configure says
> 	...
> 	AIO support       yes
> 	...
> - but isn't this raw_aio_ioctl() only used for SG_IO i.e. scsi passthru?
> (which isn't implemented for FreeBSD yet because doing direct scsi
> commands from userland works differently there than on linux.)
> 
>  Or am I confused? :)

You're not.  Currently aio_ioctl is only used for SG_IO.  But I don't
think wiring up for freebsd would hurt.  The actual posix-aio-compat.c
code for it is compiled on freebsd anyway, so hooking it up is easy,
and you're prepared if other users pop up.