From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M03C6-0007ex-KA
	for qemu-devel@nongnu.org; Fri, 01 May 2009 20:35:06 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M03C2-0007VM-3e
	for qemu-devel@nongnu.org; Fri, 01 May 2009 20:35:06 -0400
Received: from [199.232.76.173] (port=35547 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M03C1-0007VC-QW
	for qemu-devel@nongnu.org; Fri, 01 May 2009 20:35:01 -0400
Received: from mx20.gnu.org ([199.232.41.8]:44405)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1M03C1-0007c2-Aq
	for qemu-devel@nongnu.org; Fri, 01 May 2009 20:35:01 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1M03C0-0004Py-BM
	for qemu-devel@nongnu.org; Fri, 01 May 2009 20:35:00 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] Re: [PATCH 7/8] Introduce reset notifier order
Date: Sat, 2 May 2009 01:34:56 +0100
References: <20090501211717.24514.23246.stgit@mchn012c.ww002.siemens.net>
	<200905020052.07059.paul@codesourcery.com>
	<49FB8E33.3040802@web.de>
In-Reply-To: <49FB8E33.3040802@web.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200905020134.56943.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>, Jan Kiszka <jan.kiszka@web.de>, Avi Kivity <avi@redhat.com>

On Saturday 02 May 2009, Jan Kiszka wrote:
> Paul Brook wrote:
> > On Friday 01 May 2009, Jan Kiszka wrote:
> >> Add the parameter 'order' to qemu_register_reset and sort callbacks on
> >> registration. On system reset, callbacks with lower order will be
> >> invoked before those with higher order. Update all existing users to the
> >> standard order 0.
> >>
> >> Note: At least for x86, the existing users seem to assume that handlers
> >> are called in their registration order. Therefore, the patch preserves
> >> this property. If someone feels bored, (s)he could try to identify this
> >> dependency and express it properly on callback registration.
> >
> > Why do we need this? Why isn't creation order good enough?
>
> At latest when properly deregistering reset handlers again on device
> unplug, the registration order is no longer a static thing, manifested
> in the code organization - which can also break due to refactoring, BTW.

I'm afraid I can't make any sense of this. What exactly are you trying to 
solve?

Paul