From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Robert Reif <reif@earthlink.net>
Subject: Re: [Qemu-devel] [PATCH] 64 bit I/O support v7
Date: Sat, 2 May 2009 01:40:46 +0100 [thread overview]
Message-ID: <200905020140.46622.paul@codesourcery.com> (raw)
In-Reply-To: <49FB8D85.7010009@earthlink.net>
> > My guess is that in pactice we only have certain SPARC devices that need
> > to trap when you do a wrong sized access, and for everything else you're
> > told not to do that, and qemu can happily return garbage.
> >
> > If this is the case then the IO_MEM_SUBWIDTH code seems like complete
> > overkill. I reccommend ripping it out, and maybe having the registration
> > function replace NULL with the unassigned hander.
>
> Wouldn't making a version of the subpage structure the default
> and getting rid of the multiple parallel arrays make more sense.
> Then there would only be one type of I/O memory and no special
> cases.
I'm not sure what you're suggesting. I've yet to see any actual use of the
subwidth code, and the subpage stuff is fairly rare.
Trying to push the subpage code down into the TLB handler might be possible,
but you'd have to be careful to avoid performance regressions in the common
code.
Paul
next prev parent reply other threads:[~2009-05-02 0:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 11:42 [Qemu-devel] [PATCH] 64 bit I/O support v7 Robert Reif
2009-05-01 12:03 ` Paul Brook
2009-05-01 13:46 ` Robert Reif
2009-05-01 14:14 ` Paul Brook
2009-05-01 14:39 ` Robert Reif
2009-05-01 14:52 ` Paul Brook
2009-05-01 15:19 ` Robert Reif
2009-05-01 15:33 ` Paul Brook
2009-05-01 15:51 ` Blue Swirl
2009-05-01 16:36 ` Edgar E. Iglesias
2009-05-01 17:29 ` Robert Reif
2009-05-02 0:02 ` Robert Reif
2009-05-02 0:40 ` Paul Brook [this message]
2009-05-01 23:42 ` Robert Reif
2009-05-01 23:57 ` Paul Brook
2009-05-02 15:23 ` Blue Swirl
2009-05-02 19:35 ` Paul Brook
2009-05-05 1:59 ` Jamie Lokier
2009-05-05 6:05 ` Edgar E. Iglesias
2009-05-01 14:25 ` Robert Reif
2009-05-01 14:39 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905020140.46622.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=reif@earthlink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).