Re: [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration

[Gleb Natapov <gleb@redhat.com>]

On Sun, May 03, 2009 at 10:36:54AM +0300, Avi Kivity wrote:
> Gleb Natapov wrote:
>>> I don't think it's necessary.  We can record the software interrupt 
>>> at  the end of the instruction that generated it, and give it higher  
>>> priority than a pending external interrupt.  On vmx, decrement RIP 
>>> and  set entry instruction length = 1 before injection.
>>>     
>> And get wrong error value when exception happens during soft interrupt
>> delivery? I don't like all those tricks. They work only if everything
>> happens like you expected and breaks completely when it is not.
>>
>>   
>
> Er, yes.
>
>>>                                                     On svm, use 
>>> EVENTINJ  and forget about the instruction length.
>>>
>>>     
>> On SVM we do not re-inject soft int/exception at all, but re-execute the
>> offending instruction.
>>   
>
> Maybe we should unexecute the software interrupt instruction on Intel  
> and get the same effect.
>
We don't need to unexecute anything. We get exit with RIP pointing to
the offending instruction. The right thing on VMX to do is to inject
software interrupt with correct instruction length. Processor will do
the rest. Remind me please why do we try to find problems where there is
none? We will do right thing and fix migration code to do right thing.

--
			Gleb.